From 9821443150ecb42f515041b60fedb21e3d3a0a0e Mon Sep 17 00:00:00 2001 From: Andrew Scott Date: Sat, 27 Jun 2020 12:53:43 -0700 Subject: [PATCH] feat(dev-infra): add phased review to groups requiring final sign-off after initial review (#37798) The size-tracking, public-api, and circular-dependencies groups can get a lot of PRs to review. In addition, the members of these groups do not always have the necessary context to fully review the PR in question. This change ensures that the owners in the groups where the changes are being made have approve the changes (ie, the aren't pending or rejected) before requesting final sign-off from these three critical groups. PR Close #37798 --- .pullapprove.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.pullapprove.yml b/.pullapprove.yml index 6eea6693f8..7ecae6ed4c 100644 --- a/.pullapprove.yml +++ b/.pullapprove.yml @@ -1160,6 +1160,8 @@ groups: public-api: <<: *defaults conditions: + - *no-groups-above-this-pending + - *no-groups-above-this-rejected - *can-be-global-approved - > contains_any_globs(files, [ @@ -1190,6 +1192,8 @@ groups: size-tracking: <<: *defaults conditions: + - *no-groups-above-this-pending + - *no-groups-above-this-rejected - *can-be-global-approved - > contains_any_globs(files, [ @@ -1214,6 +1218,8 @@ groups: circular-dependencies: <<: *defaults conditions: + - *no-groups-above-this-pending + - *no-groups-above-this-rejected - *can-be-global-approved - > contains_any_globs(files, [