cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(forms): Validators.required properly validate arrays (#13362)

Browse Source 
Closes #12274
This commit is contained in:
Dzmitry Shylovich 2017-01-05 20:25:20 +03:00 committed by Igor Minar
parent 2dd6280ab8
commit 9898d8f6d9
2 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
modules/@angular/forms/src/validators.ts
View File

@ -14,8 +14,9 @@ import {isPresent} from './facade/lang';
import {AbstractControl} from './model'; import {AbstractControl} from './model';
import {isPromise} from './private_import_core'; import {isPromise} from './private_import_core';
function isEmptyInputValue(value: any) { function isEmptyInputValue(value: any): boolean {
return value == null || typeof value === 'string' && value.length === 0; // we don't check for string here so it also works with arrays
return value == null || value.length === 0;
} }
/** /**

6
modules/@angular/forms/test/validators_spec.ts
View File

@ -48,6 +48,12 @@ export function main() {
it('should accept zero as valid', it('should accept zero as valid',
() => { expect(Validators.required(new FormControl(0))).toBeNull(); }); () => { expect(Validators.required(new FormControl(0))).toBeNull(); });
it('should error on an empty array',
() => expect(Validators.required(new FormControl([]))).toEqual({'required': true}));
it('should not error on a non-empty array',
() => expect(Validators.required(new FormControl([1, 2]))).toBeNull());
}); });
describe('requiredTrue', () => { describe('requiredTrue', () => {