cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore(build): Remove circular dependency in Angular 2 ES5 output.

Browse Source 
Remove couple of circular dependency between modules in Angular 2 ES5 output caused by exception_handler.ts and router_providers.ts.

Fix the build/checkCircularDependency gulp task to call madge properly to detect the circular deps.

Closes #7287
This commit is contained in:
Vikram Subramanian
2016-02-25 12:04:59 -08:00
committed by vikerman
parent 7d44b8230e
commit 9936e347ff
7 changed files with 48 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
gulpfile.js
View File

@ -344,9 +344,8 @@ gulp.task('lint', ['build.tools'], function() {
gulp.task('build/checkCircularDependencies', function(done) {
var madge = require('madge');
var dependencyObject = madge(CONFIG.dest.js.dev.es5, {
var dependencyObject = madge([CONFIG.dest.js.dev.es5], {
format: 'cjs',
paths: [CONFIG.dest.js.dev.es5],
extensions: ['.js'],
onParseFile: function(data) { data.src = data.src.replace(/\/\* circular \*\//g, "//"); }
});