cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "feat(forms): formControlName also accepts a number (#30606)" (#32088)

Browse Source 
This reverts commit a647298412.

PR Close #32088
This commit is contained in:
Kara Erickson
2019-08-09 17:20:14 -07:00
parent 3df54be9e4
commit 9a37e827e2
4 changed files with 7 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/forms/src/directives/ng_control.ts
View File

@ -36,7 +36,7 @@ export abstract class NgControl extends AbstractControlDirective {
* @description
* The name for the control
*/
name: string|number|null = null;
name: string|null = null;
/**
* @description

10
packages/forms/src/directives/reactive_directives/form_control_name.ts
View File

@ -145,13 +145,9 @@ export class FormControlName extends NgControl implements OnChanges, OnDestroy {
* @description
* Tracks the name of the `FormControl` bound to the directive. The name corresponds
* to a key in the parent `FormGroup` or `FormArray`.
* Accepts a name as a string or a number.
* The name in the form of a string is useful for individual forms,
* while the numerical form allows for form controls to be bound
* to indices when iterating over controls in a `FormArray`.
*/
// TODO(issue/24571): remove '!'.
@Input('formControlName') name !: string | number | null;
@Input('formControlName') name !: string;
/**
* @description
@ -242,9 +238,7 @@ export class FormControlName extends NgControl implements OnChanges, OnDestroy {
* Returns an array that represents the path from the top-level form to this control.
* Each index is the string name of the control on that level.
*/
get path(): string[] {
return controlPath(this.name == null ? this.name : this.name.toString(), this._parent !);
}
get path(): string[] { return controlPath(this.name, this._parent !); }
/**
* @description

4
packages/forms/src/directives/shared.ts
View File

@ -28,8 +28,8 @@ import {SelectMultipleControlValueAccessor} from './select_multiple_control_valu
import {AsyncValidator, AsyncValidatorFn, Validator, ValidatorFn} from './validators';
export function controlPath(name: string | null, parent: ControlContainer): string[] {
return [...parent.path !, name !];
export function controlPath(name: string, parent: ControlContainer): string[] {
return [...parent.path !, name];
}
export function setUpControl(control: FormControl, dir: NgControl): void {