cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(pipes): rename PipeRegistry to Pipes

Browse Source 
BREAKING CHANGE:
    This change renames all instances of PipeRegistry to Pipes.
    As part of this change, the former "defaultPipes" export is
    now a Pipes instance, instead of a map. The map that was previously
    called "defaultPipes" no longer exists, but may be accessed via
    defaultPipes.config.
This commit is contained in:
Jeff Cross
2015-07-09 10:34:51 -07:00
parent 8b3efdf229
commit 9a70f84e60
20 changed files with 90 additions and 104 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
modules/angular2/test/change_detection/change_detector_spec.ts
View File

@ -29,7 +29,7 @@ import {
BindingRecord,
DirectiveRecord,
DirectiveIndex,
PipeRegistry,
Pipes,
Pipe,
CHECK_ALWAYS,
CHECK_ONCE,
@ -324,7 +324,7 @@ export function main() {
describe('pipes', () => {
it('should pass a change record to the dispatcher', () => {
var registry = new FakePipeRegistry('pipe', () => new CountingPipe());
var registry = new FakePipes('pipe', () => new CountingPipe());
var person = new Person('bob');
var val = _createChangeDetector('name | pipe', person, registry);
val.changeDetector.detectChanges();
@ -332,7 +332,7 @@ export function main() {
});
it('should support arguments in pipes', () => {
var registry = new FakePipeRegistry('pipe', () => new MultiArgPipe());
var registry = new FakePipes('pipe', () => new MultiArgPipe());
var address = new Address('two');
var person = new Person('value', address);
var val = _createChangeDetector("name | pipe:'one':address.city", person, registry);
@ -749,7 +749,7 @@ export function main() {
it('should destroy all active pipes during dehyration', () => {
var pipe = new OncePipe();
var registry = new FakePipeRegistry('pipe', () => pipe);
var registry = new FakePipes('pipe', () => pipe);
var cd = _createChangeDetector('name | pipe', new Person('bob'), registry).changeDetector;
cd.detectChanges();
@ -775,7 +775,7 @@ export function main() {
describe('pipes', () => {
it('should support pipes', () => {
var registry = new FakePipeRegistry('pipe', () => new CountingPipe());
var registry = new FakePipes('pipe', () => new CountingPipe());
var ctx = new Person('Megatron');
var val = _createChangeDetector('name | pipe', ctx, registry);
@ -791,7 +791,7 @@ export function main() {
});
it('should lookup pipes in the registry when the context is not supported', () => {
var registry = new FakePipeRegistry('pipe', () => new OncePipe());
var registry = new FakePipes('pipe', () => new OncePipe());
var ctx = new Person('Megatron');
var cd = _createChangeDetector('name | pipe', ctx, registry).changeDetector;
@ -808,7 +808,7 @@ export function main() {
it('should invoke onDestroy on a pipe before switching to another one', () => {
var pipe = new OncePipe();
var registry = new FakePipeRegistry('pipe', () => pipe);
var registry = new FakePipes('pipe', () => pipe);
var ctx = new Person('Megatron');
var cd = _createChangeDetector('name | pipe', ctx, registry).changeDetector;
@ -824,7 +824,7 @@ export function main() {
'of the encompassing component into a pipe',
() => {
var registry = new FakePipeRegistry('pipe', () => new IdentityPipe());
var registry = new FakePipes('pipe', () => new IdentityPipe());
var cd =
_createChangeDetector('name | pipe', new Person('bob'), registry).changeDetector;
@ -835,7 +835,7 @@ export function main() {
});
it('should do nothing when no change', () => {
var registry = new FakePipeRegistry('pipe', () => new IdentityPipe());
var registry = new FakePipes('pipe', () => new IdentityPipe());
var ctx = new Person('Megatron');
var val = _createChangeDetector('name | pipe', ctx, registry);
@ -851,7 +851,7 @@ export function main() {
});
it('should unwrap the wrapped value', () => {
var registry = new FakePipeRegistry('pipe', () => new WrappedPipe());
var registry = new FakePipes('pipe', () => new WrappedPipe());
var ctx = new Person('Megatron');
var val = _createChangeDetector('name | pipe', ctx, registry);
@ -915,7 +915,7 @@ class MultiArgPipe implements Pipe {
onDestroy(): void {}
}
class FakePipeRegistry extends PipeRegistry {
class FakePipes extends Pipes {
numberOfLookups: number;
pipeType: string;
factory: Function;

12
modules/angular2/test/change_detection/pipes/pipes_spec.ts
View File

@ -11,7 +11,7 @@ import {
SpyPipeFactory
} from 'angular2/test_lib';
import {PipeRegistry} from 'angular2/src/change_detection/pipes/pipes';
import {Pipes} from 'angular2/src/change_detection/pipes/pipes';
export function main() {
describe("pipe registry", () => {
@ -30,7 +30,7 @@ export function main() {
});
it("should return an existing pipe if it can support the passed in object", () => {
var r = new PipeRegistry({"type": []});
var r = new Pipes({"type": []});
firstPipe.spy("supports").andReturn(true);
@ -43,7 +43,7 @@ export function main() {
firstPipeFactory.spy("supports").andReturn(true);
firstPipeFactory.spy("create").andReturn(secondPipe);
var r = new PipeRegistry({"type": [firstPipeFactory]});
var r = new Pipes({"type": [firstPipeFactory]});
expect(r.get("type", "some object", null, firstPipe)).toEqual(secondPipe);
expect(firstPipe.spy("onDestroy")).toHaveBeenCalled();
@ -56,19 +56,19 @@ export function main() {
secondPipeFactory.spy("supports").andReturn(true);
secondPipeFactory.spy("create").andReturn(secondPipe);
var r = new PipeRegistry({"type": [firstPipeFactory, secondPipeFactory]});
var r = new Pipes({"type": [firstPipeFactory, secondPipeFactory]});
expect(r.get("type", "some object")).toBe(secondPipe);
});
it("should throw when no matching type", () => {
var r = new PipeRegistry({});
var r = new Pipes({});
expect(() => r.get("unknown", "some object"))
.toThrowError(`Cannot find 'unknown' pipe supporting object 'some object'`);
});
it("should throw when no matching pipe", () => {
var r = new PipeRegistry({"type": []});
var r = new Pipes({"type": []});
expect(() => r.get("type", "some object"))
.toThrowError(`Cannot find 'type' pipe supporting object 'some object'`);