cargdev/angular
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(ivy): rename tView.firstTemplatePass to tView.firstCreatePass (#31270)

Browse Source 
PR Close #31270
This commit is contained in:
Matias Niemelä
2019-11-01 13:06:17 -07:00
committed by atscott
parent 91147ade2e
commit 9c13d6e8e6
24 changed files with 83 additions and 83 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/core/test/render3/control_flow_spec.ts
View File

@ -691,7 +691,7 @@ describe('JS control flow', () => {
let log: string[] = [];
// Intentionally duplicating the templates in test below so we are
// testing the behavior on firstTemplatePass for each of these tests
// testing the behavior on firstCreatePass for each of these tests
class Comp {
static ɵfac =
() => {
@ -761,7 +761,7 @@ describe('JS control flow', () => {
let log: string[] = [];
// Intentionally duplicating the templates from above so we are
// testing the behavior on firstTemplatePass for each of these tests
// testing the behavior on firstCreatePass for each of these tests
class Comp {
static ɵfac =
() => {

2
packages/core/test/render3/di_spec.ts
View File

@ -145,7 +145,7 @@ describe('di', () => {
describe('bloom filter', () => {
let mockTView: any;
beforeEach(() => {
mockTView = {data: [0, 0, 0, 0, 0, 0, 0, 0, null], firstTemplatePass: true};
mockTView = {data: [0, 0, 0, 0, 0, 0, 0, 0, null], firstCreatePass: true};
});
function bloomState() { return mockTView.data.slice(0, TNODE).reverse(); }

10
packages/core/test/render3/instructions_spec.ts
View File

@ -45,7 +45,7 @@ describe('instructions', () => {
t.update(() => { ɵɵproperty('title', 'World'); });
expect(t.html).toEqual('<a title="World"></a>');
expect(ngDevMode).toHaveProperties({
firstTemplatePass: 1,
firstCreatePass: 1,
tNode: 2, // 1 for hostElement + 1 for the template under test
tView: 2, // 1 for rootView + 1 for the template view
rendererCreateElement: 1,
@ -64,7 +64,7 @@ describe('instructions', () => {
t.update();
expect(t.html).toEqual('<a title="Hello"></a>');
expect(ngDevMode).toHaveProperties({
firstTemplatePass: 1,
firstCreatePass: 1,
tNode: 2, // 1 for hostElement + 1 for the template under test
tView: 2, // 1 for rootView + 1 for the template view
rendererCreateElement: 1,
@ -83,7 +83,7 @@ describe('instructions', () => {
expect(div.id).toEqual('test');
expect(div.title).toEqual('Hello');
expect(ngDevMode).toHaveProperties({
firstTemplatePass: 1,
firstCreatePass: 1,
tNode: 2, // 1 for div, 1 for host element
tView: 2, // 1 for rootView + 1 for the template view
rendererCreateElement: 1,
@ -103,7 +103,7 @@ describe('instructions', () => {
});
expect(t.html).toEqual('<div title="javascript:true"></div>');
expect(ngDevMode).toHaveProperties({
firstTemplatePass: 1,
firstCreatePass: 1,
tNode: 2, // 1 for div, 1 for host element
tView: 2, // 1 for rootView + 1 for the template view
rendererCreateElement: 1,
@ -126,7 +126,7 @@ describe('instructions', () => {
t.update(() => { ɵɵproperty('title', 'two')('accessKey', 'B'); });
expect(t.html).toEqual('<div accesskey="B" title="two"></div>');
expect(ngDevMode).toHaveProperties({
firstTemplatePass: 1,
firstCreatePass: 1,
tNode: 2, // 1 for div, 1 for host element
tView: 2, // 1 for rootView + 1 for the template view
rendererCreateElement: 1,

2
packages/core/test/render3/integration_spec.ts
View File

@ -34,7 +34,7 @@ describe('render3 integration test', () => {
expect(renderToHtml(Template, 'once', 1, 1)).toEqual('once');
expect(renderToHtml(Template, 'twice', 1, 1)).toEqual('once');
expect(ngDevMode).toHaveProperties({
firstTemplatePass: 0,
firstCreatePass: 0,
tNode: 2,
tView: 2, // 1 for root view, 1 for template
rendererSetText: 1,