From 9ca1faf8658aaccc584ec8147800e00deb0b4ac6 Mon Sep 17 00:00:00 2001 From: Aristeidis Bampakos Date: Tue, 11 Feb 2020 09:41:55 +0200 Subject: [PATCH] docs: Fix minor typos and coding styles (#35325) - Fix minor typos in the Getting Started, Forms and AOT Compiler guide. - Fix minor typo in the Tour of Heroes app. - Fix coding styles in the Getting Started guide and the Tour of Heroes app PR Close #35325 --- .../examples/getting-started/src/app/cart/cart.component.ts | 4 ++-- .../src/app/product-details/product-details.component.ts | 2 +- aio/content/guide/aot-compiler.md | 2 +- aio/content/start/data.md | 4 ++-- aio/content/start/forms.md | 2 +- aio/content/start/index.md | 2 +- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/aio/content/examples/getting-started/src/app/cart/cart.component.ts b/aio/content/examples/getting-started/src/app/cart/cart.component.ts index 09165b0324..a076868145 100644 --- a/aio/content/examples/getting-started/src/app/cart/cart.component.ts +++ b/aio/content/examples/getting-started/src/app/cart/cart.component.ts @@ -39,10 +39,10 @@ export class CartComponent implements OnInit { // #enddocregion props-services onSubmit(customerData) { // Process checkout data here - console.warn('Your order has been submitted', customerData); - this.items = this.cartService.clearCart(); this.checkoutForm.reset(); + + console.warn('Your order has been submitted', customerData); } // #docregion props-services, inject-form-builder, checkout-form, checkout-form-group } diff --git a/aio/content/examples/getting-started/src/app/product-details/product-details.component.ts b/aio/content/examples/getting-started/src/app/product-details/product-details.component.ts index 0f53e18b04..f3731e7e65 100644 --- a/aio/content/examples/getting-started/src/app/product-details/product-details.component.ts +++ b/aio/content/examples/getting-started/src/app/product-details/product-details.component.ts @@ -39,8 +39,8 @@ export class ProductDetailsComponent implements OnInit { // #enddocregion props-methods, get-product // #docregion add-to-cart addToCart(product) { - window.alert('Your product has been added to the cart!'); this.cartService.addToCart(product); + window.alert('Your product has been added to the cart!'); } // #docregion props-methods, get-product, inject-cart-service } diff --git a/aio/content/guide/aot-compiler.md b/aio/content/guide/aot-compiler.md index 07dbb7453c..f6be4ad9fa 100644 --- a/aio/content/guide/aot-compiler.md +++ b/aio/content/guide/aot-compiler.md @@ -570,7 +570,7 @@ In the template type-checking phase, the Angular template compiler uses the Type Enable this phase explicitly by adding the compiler option `"fullTemplateTypeCheck"` in the `"angularCompilerOptions"` of the project's `tsconfig.json` (see [Angular Compiler Options](guide/angular-compiler-options)). -
In [Angular Ivy](guide/ivy), the template type checker has been completely rewritten to be more capable as well as stricter, meaning it can catch a variety of new errors that the previous type checker would not detect. diff --git a/aio/content/start/data.md b/aio/content/start/data.md index ccc04fba43..bda6d587c2 100644 --- a/aio/content/start/data.md +++ b/aio/content/start/data.md @@ -234,7 +234,7 @@ This section shows you how to use the HTTP client to retrieve shipping prices fr ### Predefined shipping data -The app StackBlitz generates for this guide comes with predefined shipping data in `assets/shipping.json`. +The application that StackBlitz generates for this guide comes with predefined shipping data in `assets/shipping.json`. Use this data to add shipping prices for items in the cart. @@ -314,7 +314,7 @@ Now that your app can retrieve shipping data, create a shipping component and t There's no link to the new shipping component yet, but you can see its template in the preview pane by entering the URL its route specifies. The URL has the pattern: `https://getting-started.stackblitz.io/shipping` where the `getting-started.stackblitz.io` part may be different for your StackBlitz project. -1. Modify the shipping component so it uses the cart service to retrieve shipping data via HTTP from the `shipping.json` file. +1. Modify the shipping component so that it uses the cart service to retrieve shipping data via HTTP from the `shipping.json` file. 1. Import the cart service. diff --git a/aio/content/start/forms.md b/aio/content/start/forms.md index 2b6216088c..aa2c789530 100644 --- a/aio/content/start/forms.md +++ b/aio/content/start/forms.md @@ -40,7 +40,7 @@ of the constructor. 1. For the checkout process, users need to submit their name and address. When they submit their order, the form should reset and the cart should clear. - 1. In `cart.component.ts`, define an `onSubmit()` method to process the form. Use the `CartService` `clearCart()` method to empty the cart items and reset the form after it is submission. In a real-world app, this method would also submit the data to an external server. The entire cart component class is as follows: + 1. In `cart.component.ts`, define an `onSubmit()` method to process the form. Use the `CartService` `clearCart()` method to empty the cart items and reset the form after its submission. In a real-world app, this method would also submit the data to an external server. The entire cart component class is as follows: diff --git a/aio/content/start/index.md b/aio/content/start/index.md index f78e4dcbce..8840abe380 100644 --- a/aio/content/start/index.md +++ b/aio/content/start/index.md @@ -92,7 +92,7 @@ To help you get going, the following steps use predefined product data from the
- `*ngFor` is a "structural directive". Structural directives shape or reshape the DOM's structure, typically by adding, removing, and manipulating the elements to which they are attached. Any directive with an asterisk, `*`, is a structural directive. + `*ngFor` is a "structural directive". Structural directives shape or reshape the DOM's structure, typically by adding, removing, and manipulating the elements to which they are attached. Directives with an asterisk, `*`, are structural directives.