cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(bazel): correct regexp test for self-references in metadata (#29346)

Browse Source 
Add a test that catches the mistake, should have had this in the previous change

PR Close #29346
This commit is contained in:
Alex Eagle 2019-03-15 15:39:12 -07:00 committed by Jason Aden
parent 3d5b98631a
commit 9d090cb3db
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/bazel/src/ng_package/packager.ts
View File

@ -415,7 +415,7 @@ export * from '${srcDirRelative(inputPath, typingsFile.replace(/\.d\.tsx?$/, '')
if (metadata.exports) { if (metadata.exports) {
// Strip re-exports which are now self-references // Strip re-exports which are now self-references
metadata.exports = metadata.exports =
metadata.exports.filter((e: {from: string}) => !relativePathRegex.test(e.from)); metadata.exports.filter((e: {from: string}) => !e.from.match(relativePathRegex));
} }
return JSON.stringify(metadata).replace(relativePathRegex, typingsRelativePath); return JSON.stringify(metadata).replace(relativePathRegex, typingsRelativePath);
} }

2
packages/bazel/test/ng_package/core_package.spec.ts
View File

@ -89,6 +89,8 @@ describe('@angular/core ng_package', () => {
.describe('angular metadata', () => { .describe('angular metadata', () => {
it('should have metadata.json files', it('should have metadata.json files',
() => { expect(shx.cat('core.metadata.json')).toContain(`"__symbolic":"module"`); }); () => { expect(shx.cat('core.metadata.json')).toContain(`"__symbolic":"module"`); });
it('should not have self-references in metadata.json',
() => { expect(shx.cat('core.metadata.json')).not.toContain(`"from":"./core"`); });
}); });
describe('fesm2015', () => { describe('fesm2015', () => {