From 9e6c677135e4128e54567f6050c45a2f234e503b Mon Sep 17 00:00:00 2001 From: Keen Yee Liau Date: Tue, 13 Aug 2019 11:24:09 -0700 Subject: [PATCH] test(language-service): Remove test for external template (#32017) The tsserver is not meant to handle HTML files, so there is no point sending an "open" request. The existing test is wrong because the quickinfo returns "const name: never", which should be "(property) WidgetComponent.name" PR Close #32017 --- .../goldens/quickinfo_externalTemplate.json | 22 ------------------- integration/language_service_plugin/test.ts | 11 ---------- 2 files changed, 33 deletions(-) delete mode 100644 integration/language_service_plugin/goldens/quickinfo_externalTemplate.json diff --git a/integration/language_service_plugin/goldens/quickinfo_externalTemplate.json b/integration/language_service_plugin/goldens/quickinfo_externalTemplate.json deleted file mode 100644 index ada1cae7cc..0000000000 --- a/integration/language_service_plugin/goldens/quickinfo_externalTemplate.json +++ /dev/null @@ -1,22 +0,0 @@ -{ - "seq": 0, - "type": "response", - "command": "quickinfo", - "request_seq": 4, - "success": true, - "body": { - "kind": "const", - "kindModifiers": "declare", - "start": { - "line": 1, - "offset": 17 - }, - "end": { - "line": 1, - "offset": 21 - }, - "displayString": "const name: never", - "documentation": "", - "tags": [] - } -} \ No newline at end of file diff --git a/integration/language_service_plugin/test.ts b/integration/language_service_plugin/test.ts index 607c17eae2..73a920b476 100644 --- a/integration/language_service_plugin/test.ts +++ b/integration/language_service_plugin/test.ts @@ -117,17 +117,6 @@ describe('Angular Language Service', () => { offset: 28, }); expect(resp2).toMatchGolden('quickinfo.json'); - - client.sendRequest('open', { - file: `${PWD}/project/app/widget.component.html`, - }); - - const resp3 = await client.sendRequest('quickinfo', { - file: `${PWD}/project/app/widget.component.html`, - line: 1, - offset: 19, - }); - expect(resp3).toMatchGolden('quickinfo_externalTemplate.json'); }); it('should perform definition', async () => {