cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(bazel): allow and ignore extra args for _ts_expected_outs (#25558)

Browse Source 
This is needed to let ts_compile_actions take explicit list of srcs and deps to generate tsc actions from another rule. This is no-op for ngc for now.

PR Close #25558
This commit is contained in:
Vikram Subramanian 2018-08-17 15:07:39 -07:00 committed by Jason Aden
parent 11e2d9da1a
commit 9ed3bd6b4f
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/bazel/src/ng_module.bzl
View File

@ -417,10 +417,10 @@ def _devmode_compile_action(ctx, inputs, outputs, tsconfig_file, node_opts):
compile_action_outputs = outputs + outs.devmode_js + outs.declarations + outs.summaries + outs.metadata compile_action_outputs = outputs + outs.devmode_js + outs.declarations + outs.summaries + outs.metadata
_compile_action(ctx, inputs, compile_action_outputs, None, tsconfig_file, node_opts) _compile_action(ctx, inputs, compile_action_outputs, None, tsconfig_file, node_opts)
def _ts_expected_outs(ctx, label): def _ts_expected_outs(ctx, label, srcs_files = []):
# rules_typescript expects a function with two arguments, but our # rules_typescript expects a function with two or more arguments, but our
# implementation doesn't use the label # implementation doesn't use the label(and **kwargs).
_ignored = [label] _ignored = [label, srcs_files]
return _expected_outs(ctx) return _expected_outs(ctx)
def ng_module_impl(ctx, ts_compile_actions): def ng_module_impl(ctx, ts_compile_actions):