From a075260751fda3bee6d99f4875cc1751ac706aee Mon Sep 17 00:00:00 2001 From: Ajit Singh Date: Wed, 10 Jun 2020 22:29:28 +0530 Subject: [PATCH] docs: document how external link icons work (#37025) After PR #36601 which added icons to all external links. Documented how this is happening via comments in scss file. For details visit PR #36601 PR Close #37025 --- aio/src/styles/0-base/_typography.scss | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/aio/src/styles/0-base/_typography.scss b/aio/src/styles/0-base/_typography.scss index 8a07876f4a..5a1b50e61d 100755 --- a/aio/src/styles/0-base/_typography.scss +++ b/aio/src/styles/0-base/_typography.scss @@ -193,6 +193,11 @@ code { } } +// The following css rule adds an icon to external links in the docs area. +// The following `folder-*` classes are applied to the `doc-viewer`component when it is displaying docs for these areas of the documentation. +// We add the icon to all external links which are identified as absolute links (those that start with `http` or https`). +// For more info see PR #36601 + .folder-api, .folder-cli, .folder-docs, @@ -213,6 +218,8 @@ code { } } + // The docs-viewer also contain links to GitHub (e.g. the edit this page icon) identified with `.github-links` class. + // We don't want to add the external link icon to these links, so we hide them. .github-links a { &[href^="http:"]::after, &[href^="https:"]::after {