cargdev/angular
1
0
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ivy): directive matching not working in some cases when preceded by styling attributes (#31942)

Browse Source 
Fixes Ivy's directive matching not capturing attribute selectors when there is one class binding, one style binding and a regular binding that precede  the attribute that would match the directive. The issue appears to come from the fact that we weren't skipping over style bindings correctly which was throwing the loop off not to go into `bindingsMode` and to skip some of the bindings when matching.

PR Close #31942
This commit is contained in:
Kristiyan Kostadinov
2019-08-01 09:01:58 +03:00
committed by Alex Rickabaugh
parent 3122f3415a
commit a2183ddb7a
2 changed files with 35 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
packages/core/src/render3/node_selector_matcher.ts
View File

@ -198,7 +198,8 @@ function findAttrIndexInNode(
} else if (
maybeAttrName === AttributeMarker.Bindings || maybeAttrName === AttributeMarker.I18n) {
bindingsMode = true;
} else if (maybeAttrName === AttributeMarker.Classes) {
} else if (
maybeAttrName === AttributeMarker.Classes || maybeAttrName === AttributeMarker.Styles) {
let value = attrs[++i];
// We should skip classes here because we have a separate mechanism for
// matching classes in projection mode.