From a25c3c5c3bd02f7d5feaa1edbaf990f04559ce6b Mon Sep 17 00:00:00 2001 From: George Kalpakas Date: Sat, 2 May 2020 16:14:13 +0300 Subject: [PATCH] build(docs-infra): remove linting from the preview server `dev` npm script (#36837) Previously, the `dev` npm script in `aio/aio-builds-setup/scripts-js/` (the PR preview server implementation) would run both linting and unit tests. This was slow and delayed the feedback loop on each change. Since the `dev` script should be run during development and give feedback as fast as possible, this commit removes the linting from the `dev` script and only keeps the unit tests. Linting is still run in the `test` npm script (which is more comprehensive). Also, in most cases the developer's IDE will show linting errors in real time in the editor. PR Close #36837 --- aio/aio-builds-setup/dockerbuild/scripts-js/package.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/aio/aio-builds-setup/dockerbuild/scripts-js/package.json b/aio/aio-builds-setup/dockerbuild/scripts-js/package.json index 8ada4263ef..3d1533b926 100644 --- a/aio/aio-builds-setup/dockerbuild/scripts-js/package.json +++ b/aio/aio-builds-setup/dockerbuild/scripts-js/package.json @@ -14,13 +14,12 @@ "predev": "yarn build || true", "dev": "run-p ~~build-watch ~~test-watch", "lint": "tslint --project tsconfig.json", - "pretest": "yarn build", + "pretest": "run-s build lint", "test": "yarn ~~test-only", "pretest-watch": "yarn pretest", "test-watch": "yarn ~~test-watch", "~~build": "tsc", "~~build-watch": "yarn ~~build --watch", - "pre~~test-only": "yarn lint", "~~test-only": "node dist/test", "~~test-watch": "nodemon --delay 1 --exec \"yarn ~~test-only\" --watch dist" },