From a4cbe3542ad2e7e14a13b6c224a7e6a6c6b7aac4 Mon Sep 17 00:00:00 2001 From: Alex Eagle Date: Thu, 11 Jan 2018 14:31:11 -0800 Subject: [PATCH] ci: disable integration/cli-hello-world test (#21492) it is non-hermetic and breaks often due to unpinned dependencies. PR Close #21492 --- integration/run_tests.sh | 23 +++++++++++++---------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/integration/run_tests.sh b/integration/run_tests.sh index 6b482e2b05..d37ff4fa7b 100755 --- a/integration/run_tests.sh +++ b/integration/run_tests.sh @@ -19,18 +19,21 @@ rm_cache mkdir $cache trap rm_cache EXIT -# We need to install `ng` but don't want to do it globally so we place it into `.ng-cli` folder. -( - mkdir -p .ng-cli - cd .ng-cli +# cli-hello-world test is disabled because it uses un-pinned dependencies +# TODO(alexeagle): re-enable when it's pinned - # workaround for https://github.com/yarnpkg/yarn/pull/4464 which causes cli to be installed into the root node_modules - echo '{"name": "ng-cli"}' > package.json - yarn init -y +# # We need to install `ng` but don't want to do it globally so we place it into `.ng-cli` folder. +# ( +# mkdir -p .ng-cli +# cd .ng-cli - yarn add @angular/cli@$ANGULAR_CLI_VERSION --cache-folder ../$cache -) -./ng-cli-create.sh cli-hello-world +# # workaround for https://github.com/yarnpkg/yarn/pull/4464 which causes cli to be installed into the root node_modules +# echo '{"name": "ng-cli"}' > package.json +# yarn init -y + +# yarn add @angular/cli@$ANGULAR_CLI_VERSION --cache-folder ../$cache +# ) +# ./ng-cli-create.sh cli-hello-world for testDir in $(ls | grep -v node_modules) ; do [[ -d "$testDir" ]] || continue