cargdev/angular
1
0
Fork 0
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

build: enable IDE type checking of $localize code (#35711)

Browse Source 
The `packages/localize/src/tools` folder was excluded
from the top level `tsconfig.json` which meant that in IDEs
these source files were not being given the correct configuration.
It was originally excluded because it required the native `node` typings
but this is no longer a requirement.

Removing this folder from the exclusion list exposed a new issue
where there was a typings mismatch between `@babel/...` sources
and the associated `@types/babel__...` typings packages.

A clean up of the package.json and yarn.lock appears to fix this.

PR Close #35711
This commit is contained in:
Pete Bacon Darwin
2020-02-27 09:32:13 +00:00
committed by atscott
parent 3e3a1ef30d
commit a55f7aeff0
3 changed files with 94 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/tsconfig.json
View File

@ -46,8 +46,6 @@
// will be removed eventually. See: FW-1392.
"http/**",
"language-service/test/project",
// requires "types": ["node"] which we don't want to be available for other code
"localize/src/tools",
"platform-server/integrationtest",
// The webworker packages have deprecated and are not made compatible with the
// strict flag. Until these packages are removed, we exclude them here.