cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: don’t use the global ng at all with closure enhanced optimizations

Browse Source 
This is needed as:
- closure declares globals itself for minified names, which sometimes clobber our `ng` global
- we can't declare a closure extern as the namespace `ng` is already used within Google for typings for angularJS (via `goog.provide('ng....')`).
This commit is contained in:
Tobias Bosch
2017-09-26 19:41:08 -07:00
committed by Victor Berchet
parent b21a1d1961
commit a7798f2a93
5 changed files with 29 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/platform-browser/src/dom/util.ts
View File

@ -28,10 +28,12 @@ export function dashCaseToCamelCase(input: string): string {
* @param value The value to export.
*/
export function exportNgVar(name: string, value: any): void {
if (!ng) {
global['ng'] = ng = (global['ng'] as{[key: string]: any} | undefined) || {};
if (typeof goog === 'undefined' || goog.DEBUG) {
// Note: we can't export `ng` when using closure enhanced optimization as:
// - closure declares globals itself for minified names, which sometimes clobber our `ng` global
// - we can't declare a closure extern as the namespace `ng` is already used within Google
// for typings for angularJS (via `goog.provide('ng....')`).
const ng = global['ng'] = (global['ng'] as{[key: string]: any} | undefined) || {};
ng[name] = value;
}
ng[name] = value;
}
let ng: {[key: string]: any}|undefined;