From a83693ddd99abe5152eb3cc393fd4f4073218176 Mon Sep 17 00:00:00 2001 From: Andrew Kushnir Date: Tue, 6 Oct 2020 21:45:28 -0700 Subject: [PATCH] refactor(core): use relative import paths in micro benchmarks (#39142) This commit updates micro benchmarks to use relative path to Ivy runtime code. Keeping absolute locations caused issues with build optimizer that retained certain symbols and they appeared in the output twice. PR Close #39142 --- packages/core/test/render3/perf/BUILD.bazel | 4 ++-- packages/core/test/render3/perf/class_binding/index.ts | 5 ++--- .../core/test/render3/perf/directive_instantiate/index.ts | 2 +- packages/core/test/render3/perf/view_destroy_hook/index.ts | 2 +- 4 files changed, 6 insertions(+), 7 deletions(-) diff --git a/packages/core/test/render3/perf/BUILD.bazel b/packages/core/test/render3/perf/BUILD.bazel index 5e2b0401ab..22cd841d2d 100644 --- a/packages/core/test/render3/perf/BUILD.bazel +++ b/packages/core/test/render3/perf/BUILD.bazel @@ -227,7 +227,7 @@ ng_rollup_bundle( ng_benchmark( name = "host_binding", - bundle = ":host_binding", + bundle = ":host_binding_lib", ) ng_rollup_bundle( @@ -240,7 +240,7 @@ ng_rollup_bundle( ng_benchmark( name = "i18n", - bundle = ":i18n", + bundle = ":i18n_lib", ) ng_rollup_bundle( diff --git a/packages/core/test/render3/perf/class_binding/index.ts b/packages/core/test/render3/perf/class_binding/index.ts index ffe818ab4b..397c327a84 100644 --- a/packages/core/test/render3/perf/class_binding/index.ts +++ b/packages/core/test/render3/perf/class_binding/index.ts @@ -5,12 +5,11 @@ * Use of this source code is governed by an MIT-style license that can be * found in the LICENSE file at https://angular.io/license */ -import {ɵɵproperty} from '@angular/core/src/core'; -import {AttributeMarker, TAttributes} from '@angular/core/src/render3/interfaces/node'; - +import {ɵɵproperty} from '../../../../src/render3/instructions/all'; import {ɵɵelement} from '../../../../src/render3/instructions/element'; import {ɵɵclassMap, ɵɵclassProp} from '../../../../src/render3/instructions/styling'; import {ComponentTemplate, RenderFlags} from '../../../../src/render3/interfaces/definition'; +import {AttributeMarker, TAttributes} from '../../../../src/render3/interfaces/node'; import {Benchmark, createBenchmark} from '../micro_bench'; import {setupTestHarness} from '../setup'; diff --git a/packages/core/test/render3/perf/directive_instantiate/index.ts b/packages/core/test/render3/perf/directive_instantiate/index.ts index dd6dba1bd1..edbd04e4a0 100644 --- a/packages/core/test/render3/perf/directive_instantiate/index.ts +++ b/packages/core/test/render3/perf/directive_instantiate/index.ts @@ -5,12 +5,12 @@ * Use of this source code is governed by an MIT-style license that can be * found in the LICENSE file at https://angular.io/license */ -import {LViewFlags, TViewType} from '@angular/core/src/render3/interfaces/view'; import {ɵɵdefineDirective, ɵɵelementEnd, ɵɵelementStart, ɵɵtext} from '../../../../src/render3/index'; import {createLView, createTNode, createTView} from '../../../../src/render3/instructions/shared'; import {RenderFlags} from '../../../../src/render3/interfaces/definition'; import {TNodeType} from '../../../../src/render3/interfaces/node'; +import {LViewFlags, TViewType} from '../../../../src/render3/interfaces/view'; import {createBenchmark} from '../micro_bench'; import {createAndRenderLView} from '../setup'; diff --git a/packages/core/test/render3/perf/view_destroy_hook/index.ts b/packages/core/test/render3/perf/view_destroy_hook/index.ts index 8c3fe61b62..e96c76f9c0 100644 --- a/packages/core/test/render3/perf/view_destroy_hook/index.ts +++ b/packages/core/test/render3/perf/view_destroy_hook/index.ts @@ -6,12 +6,12 @@ * found in the LICENSE file at https://angular.io/license */ import {OnDestroy} from '@angular/core'; -import {LViewFlags, TViewType} from '@angular/core/src/render3/interfaces/view'; import {ɵɵdefineDirective, ɵɵelement, ɵɵelementEnd, ɵɵelementStart} from '../../../../src/render3/index'; import {createLView, createTNode, createTView} from '../../../../src/render3/instructions/shared'; import {RenderFlags} from '../../../../src/render3/interfaces/definition'; import {TNodeType} from '../../../../src/render3/interfaces/node'; +import {LViewFlags, TViewType} from '../../../../src/render3/interfaces/view'; import {destroyLView} from '../../../../src/render3/node_manipulation'; import {createBenchmark} from '../micro_bench'; import {createAndRenderLView} from '../setup';