cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(class): allow class names with mixed case

Browse Source 
Fixes #3001

BREAKING CHANGE:

View renderer used to take normalized CSS class names (ex. fooBar for foo-bar).
With this change a rendered implementation gets a calss name as specified in a
template, without any transformations / normalization. This change only affects
custom view renderers that should be updated accordingly.

Closes #3264
This commit is contained in:
Pawel Kozlowski
2015-07-24 10:49:47 +02:00
parent 329a6e00dc
commit a8b57256c8
4 changed files with 35 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
modules/angular2/src/render/dom/view/proto_view_builder.ts
View File

@ -23,7 +23,12 @@ import {DomElementBinder, Event, HostAction} from './element_binder';
import * as api from '../../api';
import {NG_BINDING_CLASS, EVENT_TARGET_SEPARATOR, queryBoundTextNodeIndices} from '../util';
import {
NG_BINDING_CLASS,
EVENT_TARGET_SEPARATOR,
queryBoundTextNodeIndices,
camelCaseToDashCase
} from '../util';
export class ProtoViewBuilder {
variableBindings: Map<string, string> = new Map();
@ -366,7 +371,8 @@ function createElementPropertyBinding(ast: ASTWithSource, propertyNameInTemplate
} else if (parts[0] == ATTRIBUTE_PREFIX) {
return new api.ElementPropertyBinding(api.PropertyBindingType.ATTRIBUTE, ast, parts[1]);
} else if (parts[0] == CLASS_PREFIX) {
return new api.ElementPropertyBinding(api.PropertyBindingType.CLASS, ast, parts[1]);
return new api.ElementPropertyBinding(api.PropertyBindingType.CLASS, ast,
camelCaseToDashCase(parts[1]));
} else if (parts[0] == STYLE_PREFIX) {
var unit = parts.length > 2 ? parts[2] : null;
return new api.ElementPropertyBinding(api.PropertyBindingType.STYLE, ast, parts[1], unit);

5
modules/angular2/src/render/dom/view/view.ts
View File

@ -42,11 +42,10 @@ export class DomView {
setElementClass(elementIndex: number, className: string, isAdd: boolean) {
var element = this.boundElements[elementIndex];
var dashCasedClassName = camelCaseToDashCase(className);
if (isAdd) {
DOM.addClass(element, dashCasedClassName);
DOM.addClass(element, className);
} else {
DOM.removeClass(element, dashCasedClassName);
DOM.removeClass(element, className);
}
}