cargdev/angular
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(compiler-cli): Move diagnostics files to language service (#33809)

Browse Source 
The following files are consumed only by the language service and do not
have to be in compiler-cli:

1. expression_diagnostics.ts
2. expression_type.ts
3. typescript_symbols.ts
4. symbols.ts

PR Close #33809
This commit is contained in:
Keen Yee Liau
2019-11-13 14:26:58 -08:00
committed by Alex Rickabaugh
parent 987d2bd181
commit a9d834fe69
19 changed files with 82 additions and 145 deletions
Download Patch File Download Diff File Expand all files Collapse all files

80
packages/compiler-cli/test/diagnostics/BUILD.bazel
View File

@ -1,28 +1,11 @@
load("//tools:defaults.bzl", "jasmine_node_test", "ts_library")
ts_library(
name = "mocks",
testonly = True,
srcs = [
"mocks.ts",
],
deps = [
"//packages:types",
"//packages/compiler",
"//packages/compiler-cli",
"//packages/compiler-cli/test:test_utils",
"//packages/core",
"@npm//typescript",
],
)
# check_types_spec
ts_library(
name = "check_types_lib",
testonly = True,
srcs = ["check_types_spec.ts"],
deps = [
":mocks",
"//packages/compiler-cli",
"//packages/compiler-cli/test:test_utils",
"@npm//typescript",
@ -49,69 +32,6 @@ jasmine_node_test(
],
)
# expression_diagnostics_spec
ts_library(
name = "expression_diagnostics_lib",
testonly = True,
srcs = ["expression_diagnostics_spec.ts"],
deps = [
":mocks",
"//packages/compiler",
"//packages/compiler-cli",
"//packages/compiler-cli/test:test_utils",
"//packages/language-service",
"@npm//typescript",
],
)
jasmine_node_test(
name = "expression_diagnostics",
bootstrap = ["angular/tools/testing/init_node_spec.js"],
data = [
"//packages/common:npm_package",
"//packages/core:npm_package",
"//packages/forms:npm_package",
],
tags = [
# Disabled as these tests pertain to diagnostics in the old ngc compiler. The Ivy ngtsc
# compiler has its own tests for diagnostics.
"no-ivy-aot",
],
deps = [
":expression_diagnostics_lib",
"//packages/core",
"//tools/testing:node",
],
)
# typescript_symbols_spec
ts_library(
name = "typescript_symbols_lib",
testonly = True,
srcs = ["typescript_symbols_spec.ts"],
deps = [
":mocks",
"//packages/compiler",
"//packages/compiler-cli",
"//packages/compiler-cli/test:test_utils",
"//packages/compiler/test:test_utils",
"//packages/language-service",
"@npm//typescript",
],
)
jasmine_node_test(
name = "typescript_symbols",
bootstrap = ["angular/tools/testing/init_node_spec.js"],
data = [
],
deps = [
":typescript_symbols_lib",
"//packages/core",
"//tools/testing:node",
],
)
# typescript_version_spec
ts_library(
name = "typescript_version_lib",