cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

perf(ivy): limit creationMode checks (#31839)

Browse Source 
PR Close #31839
This commit is contained in:
Pawel Kozlowski 2019-07-26 12:38:31 +02:00 committed by Andrew Kushnir
parent 561ec6a5be
commit a9ec3db91a
1 changed files with 18 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
packages/core/src/render3/instructions/shared.ts
View File

@ -63,19 +63,11 @@ export function refreshDescendantViews(lView: LView) {
const tView = lView[TVIEW]; const tView = lView[TVIEW];
const creationMode = isCreationMode(lView); const creationMode = isCreationMode(lView);
// This needs to be set before children are processed to support recursive components.
// This must be set to false immediately after the first creation run because in an
// ngFor loop, all the views will be created together before update mode runs and turns
// off firstTemplatePass. If we don't set it here, instances will perform directive
// matching, etc again and again.
tView.firstTemplatePass = false;
// Resetting the bindingIndex of the current LView as the next steps may trigger change detection.
lView[BINDING_INDEX] = tView.bindingStartIndex;
// If this is a creation pass, we should not call lifecycle hooks or evaluate bindings.
// This will be done in the update pass.
if (!creationMode) { if (!creationMode) {
// Resetting the bindingIndex of the current LView as the next steps may trigger change
// detection.
lView[BINDING_INDEX] = tView.bindingStartIndex;
const checkNoChangesMode = getCheckNoChangesMode(); const checkNoChangesMode = getCheckNoChangesMode();
executePreOrderHooks(lView, tView, checkNoChangesMode, undefined); executePreOrderHooks(lView, tView, checkNoChangesMode, undefined);
@ -93,14 +85,22 @@ export function refreshDescendantViews(lView: LView) {
InitPhaseState.AfterContentInitHooksToBeRun, undefined); InitPhaseState.AfterContentInitHooksToBeRun, undefined);
setHostBindings(tView, lView); setHostBindings(tView, lView);
} else {
// This needs to be set before children are processed to support recursive components.
// This must be set to false immediately after the first creation run because in an
// ngFor loop, all the views will be created together before update mode runs and turns
// off firstTemplatePass. If we don't set it here, instances will perform directive
// matching, etc again and again.
tView.firstTemplatePass = false;
// We resolve content queries specifically marked as `static` in creation mode. Dynamic
// content queries are resolved during change detection (i.e. update mode), after embedded
// views are refreshed (see block above).
if (tView.staticContentQueries) {
refreshContentQueries(tView, lView);
}
} }
// We resolve content queries specifically marked as `static` in creation mode. Dynamic
// content queries are resolved during change detection (i.e. update mode), after embedded
// views are refreshed (see block above).
if (creationMode && tView.staticContentQueries) {
refreshContentQueries(tView, lView);
}
// We must materialize query results before child components are processed // We must materialize query results before child components are processed
// in case a child component has projected a container. The LContainer needs // in case a child component has projected a container. The LContainer needs