From aaa20093b23882f828ac1a96766bd4367d74aa14 Mon Sep 17 00:00:00 2001
From: Igor Minar <igor@angular.io>
Date: Fri, 5 Jun 2020 16:27:53 -0700
Subject: [PATCH] ci: special case tooling-cli-shared-api review group (#37467)

The new tooling-cli-shared-api is used to guard changes to packages/compiler-cli/src/tooling.ts
which is a private API sharing channel between Angular FW and CLI.

Changes to this file should be rare and explicitly approved by at least two members
of the CLI team.

PR Close #37467
---
 .pullapprove.yml                     | 26 ++++++++++++++++++++++++++
 packages/compiler-cli/src/tooling.ts |  9 ++++++---
 2 files changed, 32 insertions(+), 3 deletions(-)

diff --git a/.pullapprove.yml b/.pullapprove.yml
index eca4f6fe20..dfd8f3183a 100644
--- a/.pullapprove.yml
+++ b/.pullapprove.yml
@@ -843,6 +843,32 @@ groups:
         - jelbourn
 
 
+  # =========================================================
+  #  Tooling: Compiler API shared with Angular CLI
+  #
+  #  Changing this API might break Angular CLI, so we require
+  #  the CLI team to approve changes here.
+  # =========================================================
+  tooling-cli-shared-api:
+    conditions:
+      - *can-be-global-approved
+      - *can-be-global-docs-approved
+      - >
+        contains_any_globs(files, [
+          'packages/compiler-cli/src/tooling.ts'
+        ])
+    reviewers:
+      users:
+        - alan-agius4
+        - clydin
+        - kyliau
+        - IgorMinar
+    reviews:
+      request: -1   # request reviews from everyone
+      required: 2   # require at least 2 approvals
+      reviewed_for: required
+
+
   # =========================================================
   #  Docs: CLI
   # =========================================================
diff --git a/packages/compiler-cli/src/tooling.ts b/packages/compiler-cli/src/tooling.ts
index fb5ce6453d..44a7d50e21 100644
--- a/packages/compiler-cli/src/tooling.ts
+++ b/packages/compiler-cli/src/tooling.ts
@@ -7,11 +7,14 @@
  */
 
 /**
- * @module
- * @description
- * Tooling support helpers.
+ * @fileoverview
+ * This file is used as a private API channel to shared Angular FW APIs with @angular/cli.
+ *
+ * Any changes to this file should be discussed with the Angular CLI team.
  */
 
+
+
 /**
  * Known values for global variables in `@angular/core` that Terser should set using
  * https://github.com/terser-js/terser#conditional-compilation