cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(ngcc): clean up unused imports, unused regex parenthesis, typos (#37040)

Browse Source 
This is a follow-up to #37075, because I didn't manage to finish my
review before the PR got merged.

PR Close #37040
This commit is contained in:
George Kalpakas 2020-06-08 22:04:23 +03:00 committed by Misko Hevery
parent 469d2b4640
commit ab9bc8a9ec
2 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/compiler-cli/ngcc/src/dependencies/esm_dependency_host.ts
View File

@ -263,7 +263,7 @@ export class EsmDependencyHost extends DependencyHostBase {
* in this file, true otherwise. * in this file, true otherwise.
*/ */
export function hasImportOrReexportStatements(source: string): boolean { export function hasImportOrReexportStatements(source: string): boolean {
return /(?:import|export)[\s\S]+?(["'])(?:(?:\\\1|.)*?)\1/.test(source); return /(?:import|export)[\s\S]+?(["'])(?:\\\1|.)+?\1/.test(source);
} }
@ -299,4 +299,4 @@ function canPrecedeARegex(kind: ts.SyntaxKind): boolean {
default: default:
return true; return true;
} }
} }

7
packages/compiler-cli/ngcc/src/entry_point_finder/targeted_entry_point_finder.ts
View File

@ -5,18 +5,15 @@
* Use of this source code is governed by an MIT-style license that can be * Use of this source code is governed by an MIT-style license that can be
* found in the LICENSE file at https://angular.io/license * found in the LICENSE file at https://angular.io/license
*/ */
import {AbsoluteFsPath, FileSystem, join, PathSegment, relative, relativeFrom} from '../../../src/ngtsc/file_system'; import {AbsoluteFsPath, FileSystem} from '../../../src/ngtsc/file_system';
import {EntryPointWithDependencies} from '../dependencies/dependency_host';
import {DependencyResolver, SortedEntryPointsInfo} from '../dependencies/dependency_resolver'; import {DependencyResolver, SortedEntryPointsInfo} from '../dependencies/dependency_resolver';
import {Logger} from '../logging/logger'; import {Logger} from '../logging/logger';
import {hasBeenProcessed} from '../packages/build_marker'; import {hasBeenProcessed} from '../packages/build_marker';
import {NgccConfiguration} from '../packages/configuration'; import {NgccConfiguration} from '../packages/configuration';
import {EntryPoint, EntryPointJsonProperty, getEntryPointInfo, INCOMPATIBLE_ENTRY_POINT, NO_ENTRY_POINT} from '../packages/entry_point'; import {EntryPointJsonProperty} from '../packages/entry_point';
import {PathMappings} from '../path_mappings'; import {PathMappings} from '../path_mappings';
import {EntryPointFinder} from './interface';
import {TracingEntryPointFinder} from './tracing_entry_point_finder'; import {TracingEntryPointFinder} from './tracing_entry_point_finder';
import {getBasePaths} from './utils';
/** /**
* An EntryPointFinder that starts from a target entry-point and only finds * An EntryPointFinder that starts from a target entry-point and only finds