cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(docs-infra): fix docs examples for tslint rules related to variable names (#38143)

Browse Source 
This commit updates the docs examples to be compatible with the
`no-shadowed-variable` and `variable-name` tslint rules.

This is in preparation of updating the docs examples `tslint.json` to
match the one generated for new Angular CLI apps in a future commit.

PR Close #38143
This commit is contained in:
George Kalpakas
2020-07-30 13:03:16 +03:00
committed by Alex Rickabaugh
parent eb8f8c93c8
commit ac009d293d
13 changed files with 31 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
aio/content/examples/testing/src/app/hero/hero-detail.component.no-testbed.spec.ts
View File

@ -6,7 +6,6 @@ import { Hero } from '../model/hero';
////////// Tests ////////////////////
describe('HeroDetailComponent - no TestBed', () => {
let activatedRoute: ActivatedRouteStub;
let comp: HeroDetailComponent;
let expectedHero: Hero;
let hds: any;
@ -26,7 +25,6 @@ describe('HeroDetailComponent - no TestBed', () => {
// OnInit calls HDS.getHero; wait for it to get the fake hero
hds.getHero.calls.first().returnValue.subscribe(done);
});
it('should expose the hero retrieved from the service', () => {

6
aio/content/examples/testing/src/app/hero/hero-detail.component.spec.ts
View File

@ -356,14 +356,14 @@ class Page {
gotoListSpy: jasmine.Spy;
navigateSpy: jasmine.Spy;
constructor(fixture: ComponentFixture<HeroDetailComponent>) {
constructor(someFixture: ComponentFixture<HeroDetailComponent>) {
// get the navigate spy from the injected router spy object
const routerSpy = someFixture.debugElement.injector.get(Router) as any;
this.navigateSpy = routerSpy.navigate;
// spy on component's `gotoList()` method
const component = fixture.componentInstance;
this.gotoListSpy = spyOn(component, 'gotoList').and.callThrough();
const someComponent = someFixture.componentInstance;
this.gotoListSpy = spyOn(someComponent, 'gotoList').and.callThrough();
}
//// query helpers ////

2
aio/content/examples/testing/src/app/model/testing/http-client.spec.ts
View File

@ -82,7 +82,7 @@ describe('HttpClient testing', () => {
// #docregion predicate
// Expect one request with an authorization header
const req = httpTestingController.expectOne(
req => req.headers.has('Authorization')
request => request.headers.has('Authorization')
);
// #enddocregion predicate
req.flush(testData);