From ace64404607ee1dc33fe8114ebe86c673b8b3db6 Mon Sep 17 00:00:00 2001
From: Alex Eagle <alexeagle@google.com>
Date: Mon, 23 Apr 2018 16:14:34 -0700
Subject: [PATCH] ci: fix snapshot publishing (#23516)

PR Close #23516
---
 .circleci/config.yml                  | 6 +++++-
 scripts/ci/publish-build-artifacts.sh | 2 +-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/.circleci/config.yml b/.circleci/config.yml
index 8e7cb232a5..818c3c7982 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -192,8 +192,12 @@ workflows:
           # We'd really like to filter out pull requests here, but not yet available:
           # https://discuss.circleci.com/t/workflows-pull-request-filter/14396/4
           # Instead, the publish-build-artifacts.sh script just terminates when
-          # CIRCLE_PULL_REQUEST is set.
+          # CIRCLE_PR_NUMBER is set.
           requires:
+            # Only publish if tests pass
+            - test
+            # Get the artifacts to publish from the build-packages-dist job
+            # since the publishing script expects the legacy outputs layout.
             - build-packages-dist
 
   aio_monitoring:
diff --git a/scripts/ci/publish-build-artifacts.sh b/scripts/ci/publish-build-artifacts.sh
index 5e50ed2090..42686a18a2 100755
--- a/scripts/ci/publish-build-artifacts.sh
+++ b/scripts/ci/publish-build-artifacts.sh
@@ -126,7 +126,7 @@ if [ $# -gt 0 ]; then
 elif [[ \
     "$CIRCLE_PROJECT_USERNAME" == "angular" && \
     "$CIRCLE_PROJECT_REPONAME" == "angular" && \
-    ! -v CIRCLE_PULL_REQUEST ]]; then
+    ! -v CIRCLE_PR_NUMBER ]]; then
   ORG="angular"
   # $KEY is set on CI only for non-PR builds. See /.circleci/README.md
   openssl aes-256-cbc -d -in .circleci/github_token -k "${KEY}" -out "${HOME}/.git_credentials"