refactor: use new Http library in playground (#29355)

PR Close #29355
This commit is contained in:
Adam Plumer 2019-03-16 22:13:26 -05:00 committed by Andrew Kushnir
parent c99d379cc8
commit acfcf90528
7 changed files with 30 additions and 20 deletions

View File

@ -10,8 +10,8 @@ ng_module(
# TODO: FW-1004 Type checking is currently not complete. # TODO: FW-1004 Type checking is currently not complete.
type_check = False, type_check = False,
deps = [ deps = [
"//packages/common/http",
"//packages/core", "//packages/core",
"//packages/http",
"//packages/platform-browser", "//packages/platform-browser",
"//packages/platform-browser-dynamic", "//packages/platform-browser-dynamic",
"@npm//rxjs", "@npm//rxjs",

View File

@ -6,9 +6,12 @@
* found in the LICENSE file at https://angular.io/license * found in the LICENSE file at https://angular.io/license
*/ */
import {HttpClient} from '@angular/common/http';
import {Component} from '@angular/core'; import {Component} from '@angular/core';
import {Http, Response} from '@angular/http';
import {map} from 'rxjs/operators'; interface Person {
name: string;
}
@Component({ @Component({
selector: 'http-app', selector: 'http-app',
@ -16,16 +19,14 @@ import {map} from 'rxjs/operators';
<h1>people</h1> <h1>people</h1>
<ul class="people"> <ul class="people">
<li *ngFor="let person of people"> <li *ngFor="let person of people">
hello, {{person['name']}} hello, {{person.name}}
</li> </li>
</ul> </ul>
` `
}) })
export class HttpCmp { export class HttpCmp {
people: Object[]; people: Person[];
constructor(http: Http) { constructor(http: HttpClient) {
http.get('./people.json') http.get('./people.json').subscribe((people: Person[]) => this.people = people);
.pipe(map((res: Response) => res.json()))
.subscribe((people: Array<Object>) => this.people = people);
} }
} }

View File

@ -6,14 +6,15 @@
* found in the LICENSE file at https://angular.io/license * found in the LICENSE file at https://angular.io/license
*/ */
import {HttpClientModule} from '@angular/common/http';
import {NgModule} from '@angular/core'; import {NgModule} from '@angular/core';
import {HttpModule} from '@angular/http';
import {BrowserModule} from '@angular/platform-browser'; import {BrowserModule} from '@angular/platform-browser';
import {platformBrowserDynamic} from '@angular/platform-browser-dynamic'; import {platformBrowserDynamic} from '@angular/platform-browser-dynamic';
import {HttpCmp} from './app/http_comp'; import {HttpCmp} from './app/http_comp';
@NgModule({declarations: [HttpCmp], bootstrap: [HttpCmp], imports: [BrowserModule, HttpModule]}) @NgModule(
{declarations: [HttpCmp], bootstrap: [HttpCmp], imports: [BrowserModule, HttpClientModule]})
export class ExampleModule { export class ExampleModule {
} }

View File

@ -10,8 +10,8 @@ ng_module(
# TODO: FW-1004 Type checking is currently not complete. # TODO: FW-1004 Type checking is currently not complete.
type_check = False, type_check = False,
deps = [ deps = [
"//packages/common/http",
"//packages/core", "//packages/core",
"//packages/http",
"//packages/platform-browser", "//packages/platform-browser",
"//packages/platform-browser-dynamic", "//packages/platform-browser-dynamic",
], ],

View File

@ -6,8 +6,12 @@
* found in the LICENSE file at https://angular.io/license * found in the LICENSE file at https://angular.io/license
*/ */
import {HttpClient} from '@angular/common/http';
import {Component} from '@angular/core'; import {Component} from '@angular/core';
import {Jsonp} from '@angular/http';
interface Person {
name: string;
}
@Component({ @Component({
selector: 'jsonp-app', selector: 'jsonp-app',
@ -15,14 +19,14 @@ import {Jsonp} from '@angular/http';
<h1>people</h1> <h1>people</h1>
<ul class="people"> <ul class="people">
<li *ngFor="let person of people"> <li *ngFor="let person of people">
hello, {{person['name']}} hello, {{person.name}}
</li> </li>
</ul> </ul>
` `
}) })
export class JsonpCmp { export class JsonpCmp {
people: Object; people: Person[];
constructor(jsonp: Jsonp) { constructor(http: HttpClient) {
jsonp.get('./people.json?callback=JSONP_CALLBACK').subscribe(res => this.people = res.json()); http.jsonp('./people.json', 'callback').subscribe(res => this.people = res);
} }
} }

View File

@ -6,14 +6,18 @@
* found in the LICENSE file at https://angular.io/license * found in the LICENSE file at https://angular.io/license
*/ */
import {HttpClientJsonpModule, HttpClientModule} from '@angular/common/http';
import {NgModule} from '@angular/core'; import {NgModule} from '@angular/core';
import {JsonpModule} from '@angular/http';
import {BrowserModule} from '@angular/platform-browser'; import {BrowserModule} from '@angular/platform-browser';
import {platformBrowserDynamic} from '@angular/platform-browser-dynamic'; import {platformBrowserDynamic} from '@angular/platform-browser-dynamic';
import {JsonpCmp} from './app/jsonp_comp'; import {JsonpCmp} from './app/jsonp_comp';
@NgModule({bootstrap: [JsonpCmp], declarations: [JsonpCmp], imports: [BrowserModule, JsonpModule]}) @NgModule({
bootstrap: [JsonpCmp],
declarations: [JsonpCmp],
imports: [BrowserModule, HttpClientModule, HttpClientJsonpModule]
})
export class ExampleModule { export class ExampleModule {
} }

View File

@ -1,2 +1,2 @@
// This can only be requested once due to constant method name :( // This can only be requested once due to constant method name :(
__ng_jsonp__.__req0.finished([{"name":"caitp"}]) ng_jsonp_callback_0([{"name":"caitp"}])