cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

perf(change_detection): do not generate onAllChangesDone when not needed

Browse Source
This commit is contained in:
vsavkin
2015-07-31 10:35:42 -07:00
parent dd06a871b7
commit adc27398fd
5 changed files with 29 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
modules/angular2/src/transform/template_compiler/change_detector_codegen.dart
View File

@ -120,9 +120,7 @@ class _CodegenState {
${_genCheckNoChanges()}
void callOnAllChangesDone() {
${_getCallOnAllChangesDoneBody()}
}
${_maybeGenCallOnAllChangesDone()}
${_maybeGenHydrateDirectives()}
@ -190,17 +188,23 @@ class _CodegenState {
/// Generates calls to `onAllChangesDone` for all `Directive`s that request
/// them.
String _getCallOnAllChangesDoneBody() {
String _maybeGenCallOnAllChangesDone() {
// NOTE(kegluneq): Order is important!
var directiveNotifications = _directiveRecords.reversed
.where((rec) => rec.callOnAllChangesDone)
.map((rec) =>
'${_names.getDirectiveName(rec.directiveIndex)}.onAllChangesDone();')
.join('');
return '''
${_names.getDispatcherName()}.notifyOnAllChangesDone();
${directiveNotifications}
''';
'${_names.getDirectiveName(rec.directiveIndex)}.onAllChangesDone();');
if (directiveNotifications.isNotEmpty) {
return '''
void callOnAllChangesDone() {
${_names.getDispatcherName()}.notifyOnAllChangesDone();
${directiveNotifications.join('')}
}
''';
} else {
return '';
}
}
String _genDeclareFields() {