cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(core): throw error message when @Output not initialized (#19116)

Browse Source 
Closes #3664

PR Close #19116
This commit is contained in:
Aldo Roman
2017-09-08 18:41:13 -05:00
committed by Igor Minar
parent 74bce18190
commit adf510f986
3 changed files with 27 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/core/src/view/provider.ts
View File

@ -137,9 +137,15 @@ export function createDirectiveInstance(view: ViewData, def: NodeDef): any {
if (def.outputs.length) {
for (let i = 0; i < def.outputs.length; i++) {
const output = def.outputs[i];
const subscription = instance[output.propName !].subscribe(
eventHandlerClosure(view, def.parent !.nodeIndex, output.eventName));
view.disposables ![def.outputIndex + i] = subscription.unsubscribe.bind(subscription);
const outputObservable = instance[output.propName !];
if (typeof outputObservable === 'object') {
const subscription = outputObservable.subscribe(
eventHandlerClosure(view, def.parent !.nodeIndex, output.eventName));
view.disposables ![def.outputIndex + i] = subscription.unsubscribe.bind(subscription);
} else {
throw new Error(
`@Output ${output.propName} not initialized in '${instance.constructor.name}'.`);
}
}
}
return instance;