From ae7b96ba1352eb93a9d539b9e250f883f260ddb3 Mon Sep 17 00:00:00 2001 From: Daniel Date: Wed, 25 Jul 2018 13:44:47 +0200 Subject: [PATCH] docs: refactor style guide example 03-06 (#24996) docs: refactor style guide example 03-06 docs: refactor style guide example 03-06 docs: refactor style guide example 03-06 PR Close #24996 --- .../03-06/app/heroes/shared/hero.service.avoid.ts | 12 ++++-------- .../src/03-06/app/heroes/shared/hero.service.ts | 15 ++++++--------- 2 files changed, 10 insertions(+), 17 deletions(-) diff --git a/aio/content/examples/styleguide/src/03-06/app/heroes/shared/hero.service.avoid.ts b/aio/content/examples/styleguide/src/03-06/app/heroes/shared/hero.service.avoid.ts index 3b983f5bda..fea2e49d99 100644 --- a/aio/content/examples/styleguide/src/03-06/app/heroes/shared/hero.service.avoid.ts +++ b/aio/content/examples/styleguide/src/03-06/app/heroes/shared/hero.service.avoid.ts @@ -3,9 +3,8 @@ /* avoid */ import { ExceptionService, SpinnerService, ToastService } from '../../core'; -import { Http } from '@angular/http'; +import { HttpClient } from '@angular/common/http'; import { Injectable } from '@angular/core'; -import { map } from 'rxjs/operators'; import { Hero } from './hero.model'; // #enddocregion example @@ -16,18 +15,15 @@ export class HeroService { private exceptionService: ExceptionService, private spinnerService: SpinnerService, private toastService: ToastService, - private http: Http + private http: HttpClient ) { } getHero(id: number) { - return this.http.get(`api/heroes/${id}`).pipe( - map(response => response.json().data as Hero)); + return this.http.get(`api/heroes/${id}`); } getHeroes() { - return this.http.get(`api/heroes`).pipe( - map(response => response.json().data as Hero[])); + return this.http.get(`api/heroes`); } } - diff --git a/aio/content/examples/styleguide/src/03-06/app/heroes/shared/hero.service.ts b/aio/content/examples/styleguide/src/03-06/app/heroes/shared/hero.service.ts index 0a50c11bb4..0dd5931a7a 100644 --- a/aio/content/examples/styleguide/src/03-06/app/heroes/shared/hero.service.ts +++ b/aio/content/examples/styleguide/src/03-06/app/heroes/shared/hero.service.ts @@ -1,11 +1,11 @@ // #docregion // #docregion example +import { HttpClient } from '@angular/common/http'; import { Injectable } from '@angular/core'; -import { Http } from '@angular/http'; -import { map } from 'rxjs/operators'; -import { Hero } from './hero.model'; import { ExceptionService, SpinnerService, ToastService } from '../../core'; +import { Hero } from './hero.model'; + // #enddocregion example @Injectable() @@ -16,18 +16,15 @@ export class HeroService { private exceptionService: ExceptionService, private spinnerService: SpinnerService, private toastService: ToastService, - private http: Http + private http: HttpClient ) { } getHero(id: number) { - return this.http.get(`api/heroes/${id}`).pipe( - map(response => response.json() as Hero)); + return this.http.get(`api/heroes/${id}`); } getHeroes() { - return this.http.get(`api/heroes`).pipe( - map(response => response.json() as Hero[])); + return this.http.get(`api/heroes`); } } -