From affae99b22e5ec667b9db5c35b42f19bbce09535 Mon Sep 17 00:00:00 2001
From: Pawel Kozlowski <pkozlowski.opensource@gmail.com>
Date: Fri, 4 Oct 2019 12:11:52 +0200
Subject: [PATCH] perf(ivy): add static attributes to the element_text_create
 benchmark (#32997)

PR Close #32997
---
 .../render3/perf/element_text_create/index.ts | 23 +++++++++++--------
 .../core/test/render3/perf/noop_renderer.ts   |  5 +---
 2 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/packages/core/test/render3/perf/element_text_create/index.ts b/packages/core/test/render3/perf/element_text_create/index.ts
index 5bbd81c8fb..2b1f03733d 100644
--- a/packages/core/test/render3/perf/element_text_create/index.ts
+++ b/packages/core/test/render3/perf/element_text_create/index.ts
@@ -14,6 +14,9 @@ import {resetComponentState} from '../../../../src/render3/state';
 import {createBenchmark} from '../micro_bench';
 import {createAndRenderLView} from '../setup';
 
+const attrs =
+    ['name1', 'value1', 'name2', 'value2', 'name3', 'value3', 'name4', 'value4', 'name5', 'value5'];
+
 `<div>
     <button>0</button>
     <button>1</button>
@@ -30,34 +33,34 @@ import {createAndRenderLView} from '../setup';
 function testTemplate(rf: RenderFlags, ctx: any) {
   if (rf & 1) {
     ɵɵelementStart(0, 'div');
-    ɵɵelementStart(1, 'button');
+    ɵɵelementStart(1, 'button', attrs);
     ɵɵtext(2, '0');
     ɵɵelementEnd();
-    ɵɵelementStart(3, 'button');
+    ɵɵelementStart(3, 'button', attrs);
     ɵɵtext(4, '1');
     ɵɵelementEnd();
-    ɵɵelementStart(5, 'button');
+    ɵɵelementStart(5, 'button', attrs);
     ɵɵtext(6, '2');
     ɵɵelementEnd();
-    ɵɵelementStart(7, 'button');
+    ɵɵelementStart(7, 'button', attrs);
     ɵɵtext(8, '3');
     ɵɵelementEnd();
-    ɵɵelementStart(9, 'button');
+    ɵɵelementStart(9, 'button', attrs);
     ɵɵtext(10, '4');
     ɵɵelementEnd();
-    ɵɵelementStart(11, 'button');
+    ɵɵelementStart(11, 'button', attrs);
     ɵɵtext(12, '5');
     ɵɵelementEnd();
-    ɵɵelementStart(13, 'button');
+    ɵɵelementStart(13, 'button', attrs);
     ɵɵtext(14, '6');
     ɵɵelementEnd();
-    ɵɵelementStart(15, 'button');
+    ɵɵelementStart(15, 'button', attrs);
     ɵɵtext(16, '7');
     ɵɵelementEnd();
-    ɵɵelementStart(17, 'button');
+    ɵɵelementStart(17, 'button', attrs);
     ɵɵtext(18, '8');
     ɵɵelementEnd();
-    ɵɵelementStart(19, 'button');
+    ɵɵelementStart(19, 'button', attrs);
     ɵɵtext(20, '9');
     ɵɵelementEnd();
     ɵɵelementEnd();
diff --git a/packages/core/test/render3/perf/noop_renderer.ts b/packages/core/test/render3/perf/noop_renderer.ts
index e9c6c589bb..fbc5974444 100644
--- a/packages/core/test/render3/perf/noop_renderer.ts
+++ b/packages/core/test/render3/perf/noop_renderer.ts
@@ -32,11 +32,8 @@ export class NoopRenderer implements ProceduralRenderer3 {
   parentNode(node: RNode): RElement|null { throw new Error('Method not implemented.'); }
   nextSibling(node: RNode): RNode|null { throw new Error('Method not implemented.'); }
   setAttribute(el: RElement, name: string, value: string, namespace?: string|null|undefined): void {
-    throw new Error('Method not implemented.');
-  }
-  removeAttribute(el: RElement, name: string, namespace?: string|null|undefined): void {
-    throw new Error('Method not implemented.');
   }
+  removeAttribute(el: RElement, name: string, namespace?: string|null|undefined): void {}
   addClass(el: RElement, name: string): void {}
   removeClass(el: RElement, name: string): void {}
   setStyle(el: RElement, style: string, value: any, flags?: RendererStyleFlags3|undefined): void {}