cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(parser): detect and report interpolation in expressions

Browse Source 
Fixes #3645

Closes #3750
This commit is contained in:
Pawel Kozlowski
2015-08-20 16:34:47 +02:00
parent 5ee9630be1
commit b039ec3da3
3 changed files with 56 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
modules/angular2/test/change_detection/parser/parser_spec.ts
View File

@ -204,6 +204,11 @@ export function main() {
it('should store the passed-in location',
() => { expect(parseAction('someExpr', 'location').location).toBe('location'); });
it("should throw when encountering interpolation", () => {
expectActionError("{{a()}}")
.toThrowErrorWith('Got interpolation ({{}}) where expression was expected');
});
});
describe("general error handling", () => {
@ -256,6 +261,11 @@ export function main() {
it('should throw on assignment', () => {
expect(() => parseBinding("a=2")).toThrowError(new RegExp("contain assignments"));
});
it('should throw when encountering interpolation', () => {
expectBindingError("{{a.b}}")
.toThrowErrorWith('Got interpolation ({{}}) where expression was expected');
});
});
describe('parseTemplateBindings', () => {
@ -398,12 +408,12 @@ export function main() {
it("should throw on empty interpolation expressions", () => {
expect(() => parseInterpolation("{{}}"))
.toThrowError(new RegExp(
"Parser Error: Blank expressions are not allowed in interpolated strings"));
.toThrowErrorWith(
"Parser Error: Blank expressions are not allowed in interpolated strings");
expect(() => parseInterpolation("foo {{ }}"))
.toThrowError(new RegExp(
"Parser Error: Blank expressions are not allowed in interpolated strings"));
.toThrowErrorWith(
"Parser Error: Blank expressions are not allowed in interpolated strings");
});
});
@ -420,8 +430,13 @@ export function main() {
it("should throw when the given expression is not just a field name", () => {
expect(() => parseSimpleBinding("name + 1"))
.toThrowError(new RegExp(
'Simple binding expression can only contain field access and constants'));
.toThrowErrorWith(
'Simple binding expression can only contain field access and constants');
});
it('should throw when encountering interpolation', () => {
expect(() => parseSimpleBinding('{{exp}}'))
.toThrowErrorWith('Got interpolation ({{}}) where expression was expected');
});
});