From b0d27ee896cfeaa4a290bd4fed26086956522cd1 Mon Sep 17 00:00:00 2001 From: Marc Laval Date: Thu, 20 Aug 2015 10:12:46 +0200 Subject: [PATCH] chore(build): add IE10 to CI --- modules/angular2/src/dom/browser_adapter.ts | 6 ++++-- modules/angular2/test/core/compiler/integration_spec.ts | 9 +++++---- sauce.conf.js | 2 +- 3 files changed, 10 insertions(+), 7 deletions(-) diff --git a/modules/angular2/src/dom/browser_adapter.ts b/modules/angular2/src/dom/browser_adapter.ts index ddd52cb2f1..d0548f1fe2 100644 --- a/modules/angular2/src/dom/browser_adapter.ts +++ b/modules/angular2/src/dom/browser_adapter.ts @@ -299,8 +299,10 @@ export class BrowserDomAdapter extends GenericBrowserDomAdapter { } resetBaseElement(): void { baseElement = null; } getUserAgent(): string { return window.navigator.userAgent; } - setData(element, name: string, value: string) { element.dataset[name] = value; } - getData(element, name: string): string { return element.dataset[name]; } + setData(element, name: string, value: string) { + this.setAttribute(element, 'data-' + name, value); + } + getData(element, name: string): string { return this.getAttribute(element, 'data-' + name); } // TODO(tbosch): move this into a separate environment class once we have it setGlobalVar(name: string, value: any) { global[name] = value; } } diff --git a/modules/angular2/test/core/compiler/integration_spec.ts b/modules/angular2/test/core/compiler/integration_spec.ts index 42e2b77baf..aba8405e68 100644 --- a/modules/angular2/test/core/compiler/integration_spec.ts +++ b/modules/angular2/test/core/compiler/integration_spec.ts @@ -1060,7 +1060,7 @@ export function main() { var tc = rootTC.componentViewChildren[0]; var needsAttribute = tc.inject(NeedsAttribute); expect(needsAttribute.typeAttribute).toEqual('text'); - expect(needsAttribute.titleAttribute).toEqual(''); + expect(needsAttribute.staticAttribute).toEqual(''); expect(needsAttribute.fooAttribute).toEqual(null); async.done(); @@ -1886,12 +1886,13 @@ class IdDir { @Injectable() class NeedsAttribute { typeAttribute; - titleAttribute; + staticAttribute; fooAttribute; - constructor(@Attribute('type') typeAttribute: String, @Attribute('title') titleAttribute: String, + constructor(@Attribute('type') typeAttribute: String, + @Attribute('static') staticAttribute: String, @Attribute('foo') fooAttribute: String) { this.typeAttribute = typeAttribute; - this.titleAttribute = titleAttribute; + this.staticAttribute = staticAttribute; this.fooAttribute = fooAttribute; } } diff --git a/sauce.conf.js b/sauce.conf.js index 4dbb84d6b3..84a9e088e1 100644 --- a/sauce.conf.js +++ b/sauce.conf.js @@ -125,7 +125,7 @@ var aliases = { 'SAFARI': ['SL_SAFARI7', 'SL_SAFARI8'], 'BETA': ['SL_CHROMEBETA', 'SL_FIREFOXBETA'], 'DEV': ['SL_CHROMEDEV', 'SL_FIREFOXDEV'], - 'CI': ['SL_CHROME', 'SL_ANDROID5.1', 'SL_SAFARI8', 'SL_IOS8', 'SL_FIREFOX', 'SL_IE11'] + 'CI': ['SL_CHROME', 'SL_ANDROID5.1', 'SL_SAFARI8', 'SL_IOS8', 'SL_FIREFOX', 'SL_IE11', 'SL_IE10'] }; module.exports = {