cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

build(core): improve payload size failure message (#21346)

Browse Source 
PR Close #21346
This commit is contained in:
Kara Erickson 2018-01-05 15:44:45 -08:00
parent db55e86e91
commit b15d50af9b
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
scripts/ci/payload-size.js
View File

@ -23,8 +23,13 @@ for (const compressionType in limitSizes) {
if (Math.abs(actualSize - expectedSize) > expectedSize / 100) { if (Math.abs(actualSize - expectedSize) > expectedSize / 100) {
failed = true; failed = true;
// We must also catch when the size is significantly lower than the payload limit, so
// we are forced to update the expected payload number when the payload size reduces.
// Otherwise, we won't be able to catch future regressions that happen to be below
// the artificially inflated limit.
const operator = actualSize > expectedSize ? 'exceeded' : 'fell below';
console.log( console.log(
`Commit ${commit} ${compressionType} ${filename} exceeded expected size by >1% ` + `Commit ${commit} ${compressionType} ${filename} ${operator} expected size by >1% ` +
`(expected: ${expectedSize}, actual: ${actualSize}).`); `(expected: ${expectedSize}, actual: ${actualSize}).`);
} }
} }