From b1a79fd2ec188e7d75a5e8064f588b4d022bee7b Mon Sep 17 00:00:00 2001 From: Igor Minar Date: Fri, 10 Feb 2017 21:22:58 -0800 Subject: [PATCH] ci: simplify validate-commit-message empty line logic --- tools/gulp-tasks/validate-commit-message.js | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/tools/gulp-tasks/validate-commit-message.js b/tools/gulp-tasks/validate-commit-message.js index a0ce47f596..4ca2837abd 100644 --- a/tools/gulp-tasks/validate-commit-message.js +++ b/tools/gulp-tasks/validate-commit-message.js @@ -13,12 +13,8 @@ module.exports = (gulp) => () => { } let someCommitsInvalid = false; - let commitsByLine = stdout.trim().split(/\n/); - for (var i = 0; i < commitsByLine.length; i++) { - if (!commitsByLine[i]) { - commitsByLine.splice(i, 1); - } - } + let commitsByLine = stdout.trim().split(/\n/).filter(line => line != ''); + console.log(`Examining ${commitsByLine.length} commits between HEAD and master`); if (commitsByLine.length == 0) {