From b20c5d2c377163e8a9b07e5d18eafa09b296c3cb Mon Sep 17 00:00:00 2001 From: Rado Kirov Date: Tue, 5 Sep 2017 22:44:32 -0700 Subject: [PATCH] fix(upgrade): remove code setting id attribute. (#19182) The id was leftover from previous iterations of ngUpgrade and is no longer needed. Moreover, setting it can clash with CSS usage of id. Fixes #18446 PR Close #19182 --- packages/upgrade/src/common/downgrade_component_adapter.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/upgrade/src/common/downgrade_component_adapter.ts b/packages/upgrade/src/common/downgrade_component_adapter.ts index ede2efa28f..6c9de88f2f 100644 --- a/packages/upgrade/src/common/downgrade_component_adapter.ts +++ b/packages/upgrade/src/common/downgrade_component_adapter.ts @@ -31,7 +31,6 @@ export class DowngradeComponentAdapter { private parentInjector: Injector, private $injector: angular.IInjectorService, private $compile: angular.ICompileService, private $parse: angular.IParseService, private componentFactory: ComponentFactory) { - (this.element[0] as any).id = id; this.componentScope = scope.$new(); }