cargdev/angular
1
0
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

build: update jasmine to 3.5 (#34625)

Browse Source 
1. update jasmine to 3.5
2. update @types/jasmine to 3.5
3. update @types/jasminewd2 to 2.0.8

Also fix several cases, the new jasmine 3 will help to create test cases correctly,
such as in the `jasmine 2.x` version, the following case will pass

```
expect(1 == 2);
```

But in jsamine 3, the case will need to be

```
expect(1 == 2).toBeTrue();
```

PR Close #34625
This commit is contained in:
JiaLiPassion
2020-01-03 14:28:06 +09:00
committed by Kara Erickson
parent 52ab9397a0
commit b28a5f6eef
29 changed files with 124 additions and 85 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/core/test/linker/change_detection_integration_spec.ts
View File

@ -683,8 +683,10 @@ const TEST_COMPILER_PROVIDERS: Provider[] = [
fakeAsync(() => {
const ctx = createCompFixture('<div testDirective [a]="42"></div>');
const rf = TestBed.inject(RendererFactory2);
spyOn(rf, 'begin');
spyOn(rf, 'end');
// TODO: @JiaLiPassion, need to wait @types/jasmine to fix the
// optional method infer issue.
spyOn(rf as any, 'begin');
spyOn(rf as any, 'end');
expect(rf.begin).not.toHaveBeenCalled();
expect(rf.end).not.toHaveBeenCalled();