cargdev/angular
1
0
Fork 0
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

build: update jasmine to 3.5 (#34625)

Browse Source 
1. update jasmine to 3.5
2. update @types/jasmine to 3.5
3. update @types/jasminewd2 to 2.0.8

Also fix several cases, the new jasmine 3 will help to create test cases correctly,
such as in the `jasmine 2.x` version, the following case will pass

```
expect(1 == 2);
```

But in jsamine 3, the case will need to be

```
expect(1 == 2).toBeTrue();
```

PR Close #34625
This commit is contained in:
JiaLiPassion
2020-01-03 14:28:06 +09:00
committed by Kara Erickson
parent 52ab9397a0
commit b28a5f6eef
29 changed files with 124 additions and 85 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/elements/test/utils_spec.ts
View File

@ -15,7 +15,9 @@ describe('utils', () => {
let clearTimeoutSpy: jasmine.Spy;
beforeEach(() => {
setTimeoutSpy = spyOn(window, 'setTimeout').and.returnValue(42);
// TODO: @JiaLiPassion, need to wait @types/jasmine to fix the wrong return
// type infer issue.
setTimeoutSpy = spyOn(window, 'setTimeout').and.returnValue(42 as any);
clearTimeoutSpy = spyOn(window, 'clearTimeout');
});