cargdev/angular
1
0
Fork 0
Code Issues 10 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(compiler): keep DOM.hasProperty in sync between browser and transformer.

Browse Source 
Right now, we always return true until
we have property schema support (#2014).

Fixes #2984
Closes #2981
This commit is contained in:
Tobias Bosch
2015-07-13 11:43:56 -07:00
parent 7ee6963f5d
commit b3a763a718
4 changed files with 71 additions and 63 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
modules/angular2/src/dom/browser_adapter.dart
View File

@ -98,17 +98,19 @@ final _keyCodeToKeyMap = const {
class BrowserDomAdapter extends GenericBrowserDomAdapter {
js.JsFunction _setProperty;
js.JsFunction _getProperty;
js.JsFunction _hasProperty;
BrowserDomAdapter() {
_setProperty = js.context.callMethod('eval', ['(function(el, prop, value) { el[prop] = value; })']);
_setProperty = js.context.callMethod('eval', ['(function(el, prop, value) { if (prop in el) el[prop] = value; })']);
_getProperty = js.context.callMethod('eval', ['(function(el, prop) { return el[prop]; })']);
_hasProperty = js.context.callMethod('eval', ['(function(el, prop) { return prop in el; })']);
}
static void makeCurrent() {
setRootDomAdapter(new BrowserDomAdapter());
}
bool hasProperty(Element element, String name) =>
_hasProperty.apply([element, name]);
bool hasProperty(Element element, String name) {
// Always return true as the serverside version html_adapter.dart does so.
// TODO: change this once we have schema support.
// Note: This nees to kept in sync with html_adapter.dart!
return true;
}
void setProperty(Element element, String name, Object value) =>
_setProperty.apply([element, name, value]);

4
modules/angular2/src/dom/html_adapter.dart
View File

@ -11,7 +11,9 @@ class Html5LibDomAdapter implements DomAdapter {
}
hasProperty(element, String name) {
// This is needed for serverside compile to generate the right getters/setters...
// This is needed for serverside compile to generate the right getters/setters.
// TODO: change this once we have property schema support.
// Attention: Keep this in sync with browser_adapter.dart!
return true;
}