feat(core): upgrade rxjs to 6.0.0-alpha.4 (#22573)

PR Close #22573

packages/core/package.json

@@ -16,7 +16,7 @@
     "tslib": "^1.9.0"
   },
   "peerDependencies": {
-    "rxjs": "^5.5.0",
+    "rxjs": "^6.0.0-alpha.3",
     "zone.js": "^0.8.4"
   },
   "repository": {

packages/core/rollup.config.js

@@ -10,12 +10,8 @@ const resolve = require('rollup-plugin-node-resolve');
 const sourcemaps = require('rollup-plugin-sourcemaps');
 
 const globals = {
-  'rxjs/Observable': 'Rx',
-  'rxjs/Subject': 'Rx',
-  'rxjs/Observer': 'Rx',
-  'rxjs/Subscription': 'Rx',
-  'rxjs/observable/merge': 'Rx.Observable',
-  'rxjs/operator/share': 'Rx.Observable.prototype'
+  'rxjs': 'rxjs',
+  'rxjs/operators': 'rxjs.operators'
 };
 
 module.exports = {

packages/core/src/application_ref.ts

@@ -6,11 +6,8 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {Observable} from 'rxjs/Observable';
-import {Observer} from 'rxjs/Observer';
-import {Subscription} from 'rxjs/Subscription';
-import {merge} from 'rxjs/observable/merge';
-import {share} from 'rxjs/operator/share';
+import {Observable, Observer, Subscription, merge} from 'rxjs';
+import {share} from 'rxjs/operators';
 
 import {ErrorHandler} from '../src/error_handler';
 import {scheduleMicroTask, stringify} from '../src/util';
@@ -445,7 +442,7 @@ export class ApplicationRef {
     });
 
     (this as{isStable: Observable<boolean>}).isStable =
-        merge(isCurrentlyStable, share.call(isStable));
+        merge(isCurrentlyStable, isStable.pipe(share()));
   }
 
   /**

packages/core/src/event_emitter.ts

@@ -6,8 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {Subject} from 'rxjs/Subject';
-import {Subscription} from 'rxjs/Subscription';
+import {Subject, Subscription} from 'rxjs';
 
 /**
  * Use by directives and components to emit custom Events.

packages/core/src/linker/query_list.ts

@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {Observable} from 'rxjs/Observable';
+import {Observable} from 'rxjs';
 
 import {EventEmitter} from '../event_emitter';
 import {getSymbolIterator} from '../util';

packages/core/src/render3/query.ts

@@ -8,7 +8,7 @@
 
 // We are temporarily importing the existing viewEngine_from core so we can be sure we are
 // correctly implementing its interfaces for backwards compatibility.
-import {Observable} from 'rxjs/Observable';
+import {Observable} from 'rxjs';
 
 import {EventEmitter} from '../event_emitter';
 import {QueryList as viewEngine_QueryList} from '../linker/query_list';

packages/core/src/util/lang.ts

@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {Observable} from 'rxjs/Observable';
+import {Observable} from 'rxjs';
 
 /**
  * Determine if the argument is shaped like a Promise

packages/core/test/bundling/hello_world/bundle.golden_symbols.json

@@ -1,9 +1,24 @@
 [
+  {
+    "name": "Action"
+  },
+  {
+    "name": "AnimationFrameAction"
+  },
+  {
+    "name": "AsapAction"
+  },
+  {
+    "name": "AsyncAction"
+  },
+  {
+    "name": "AsyncScheduler"
+  },
   {
     "name": "CLEAN_PROMISE"
   },
   {
-    "name": "EMPTY$1"
+    "name": "EMPTY$2"
   },
   {
     "name": "EMPTY_RENDERER_TYPE_ID"
@@ -14,6 +29,9 @@
   {
     "name": "INeedToExistEvenThoughtIAmNotNeeded"
   },
+  {
+    "name": "Immediate"
+  },
   {
     "name": "NG_HOST_SYMBOL"
   },
@@ -21,26 +39,65 @@
     "name": "NG_PROJECT_AS_ATTR_NAME"
   },
   {
-    "name": "Symbol$1"
+    "name": "Observable"
+  },
+  {
+    "name": "QueueAction"
+  },
+  {
+    "name": "SafeSubscriber"
+  },
+  {
+    "name": "Scheduler"
+  },
+  {
+    "name": "Subscriber"
+  },
+  {
+    "name": "Subscription"
   },
   {
     "name": "UNDEFINED_RENDERER_TYPE_ID"
   },
   {
-    "name": "__global$1"
+    "name": "UnsubscriptionError"
   },
   {
-    "name": "__self$1"
+    "name": "__extends$1"
   },
   {
-    "name": "__window$1"
+    "name": "__extends$10"
+  },
+  {
+    "name": "__extends$11"
+  },
+  {
+    "name": "__extends$12"
+  },
+  {
+    "name": "__extends$13"
+  },
+  {
+    "name": "__extends$14"
+  },
+  {
+    "name": "__extends$17"
+  },
+  {
+    "name": "__extends$18"
+  },
+  {
+    "name": "__extends$19"
+  },
+  {
+    "name": "__extends$2"
+  },
+  {
+    "name": "__extends$20"
   },
   {
     "name": "_renderCompCount"
   },
-  {
-    "name": "_root"
-  },
   {
     "name": "appendChild"
   },
@@ -59,6 +116,9 @@
   {
     "name": "componentRefresh"
   },
+  {
+    "name": "config"
+  },
   {
     "name": "createLNode"
   },
@@ -83,9 +143,15 @@
   {
     "name": "domRendererFactory3"
   },
+  {
+    "name": "empty"
+  },
   {
     "name": "enterView"
   },
+  {
+    "name": "errorObject"
+  },
   {
     "name": "executeHooks"
   },
@@ -95,6 +161,9 @@
   {
     "name": "executeInitHooks"
   },
+  {
+    "name": "flattenUnsubscriptionErrors"
+  },
   {
     "name": "getDirectiveInstance"
   },
@@ -102,7 +171,10 @@
     "name": "getOrCreateTView"
   },
   {
-    "name": "getSymbolObservable"
+    "name": "getPromiseCtor"
+  },
+  {
+    "name": "getSymbolIterator$1"
   },
   {
     "name": "hostElement"
@@ -113,6 +185,15 @@
   {
     "name": "invertObject"
   },
+  {
+    "name": "isArray"
+  },
+  {
+    "name": "isFunction"
+  },
+  {
+    "name": "isObject"
+  },
   {
     "name": "isProceduralRenderer"
   },
@@ -122,6 +203,18 @@
   {
     "name": "locateHostElement"
   },
+  {
+    "name": "nextHandle"
+  },
+  {
+    "name": "noop"
+  },
+  {
+    "name": "observable"
+  },
+  {
+    "name": "pipeFromArray"
+  },
   {
     "name": "refreshChildComponents"
   },
@@ -149,6 +242,12 @@
   {
     "name": "rootDirectiveIndices"
   },
+  {
+    "name": "runIfPresent"
+  },
+  {
+    "name": "rxSubscriber"
+  },
   {
     "name": "setHostBindings"
   },
@@ -159,11 +258,20 @@
     "name": "stringify$1"
   },
   {
-    "name": "symbolIteratorPonyfill"
+    "name": "tasksByHandle"
   },
   {
     "name": "text"
   },
+  {
+    "name": "toSubscriber"
+  },
+  {
+    "name": "tryCatch"
+  },
+  {
+    "name": "tryCatcher"
+  },
   {
     "name": "viewAttached"
   }

packages/core/test/bundling/hello_world/treeshaking_spec.ts

@@ -18,6 +18,14 @@ const PACKAGE = 'angular/packages/core/test/bundling/hello_world';
 import * as domino from 'domino';
 
 describe('treeshaking with uglify', () => {
+
+  beforeAll(() => {
+    // initialize window so that when rxjs is loaded it is loaded and initialized as if it was
+    // loaded in a browser
+    // even when the test runs in node
+    (global as any).window = domino.createWindow('', 'http://localhost');
+  });
+
   let content: string;
   const contentPath = require.resolve(path.join(PACKAGE, 'bundle.min_debug.js'));
   beforeAll(() => { content = fs.readFileSync(contentPath, UTF8); });
@@ -51,4 +59,4 @@ describe('treeshaking with uglify', () => {
          expect(document.body.textContent).toEqual('Hello World!');
        }));
   });
-});
+});

packages/core/test/bundling/injection/bundle.golden_symbols.json

@@ -2,6 +2,21 @@
   {
     "name": "APP_ROOT"
   },
+  {
+    "name": "Action"
+  },
+  {
+    "name": "AnimationFrameAction"
+  },
+  {
+    "name": "AsapAction"
+  },
+  {
+    "name": "AsyncAction"
+  },
+  {
+    "name": "AsyncScheduler"
+  },
   {
     "name": "CIRCULAR$1"
   },
@@ -14,6 +29,9 @@
   {
     "name": "INJECTOR$1"
   },
+  {
+    "name": "Immediate"
+  },
   {
     "name": "Inject"
   },
@@ -29,15 +47,27 @@
   {
     "name": "NullInjector"
   },
+  {
+    "name": "Observable"
+  },
   {
     "name": "Optional"
   },
   {
     "name": "PARAMETERS"
   },
+  {
+    "name": "QueueAction"
+  },
   {
     "name": "R3Injector"
   },
+  {
+    "name": "SafeSubscriber"
+  },
+  {
+    "name": "Scheduler"
+  },
   {
     "name": "ScopedService"
   },
@@ -48,7 +78,10 @@
     "name": "SkipSelf"
   },
   {
-    "name": "Symbol$1"
+    "name": "Subscriber"
+  },
+  {
+    "name": "Subscription"
   },
   {
     "name": "THROW_IF_NOT_FOUND"
@@ -56,29 +89,56 @@
   {
     "name": "USE_VALUE$1"
   },
+  {
+    "name": "UnsubscriptionError"
+  },
   {
     "name": "_THROW_IF_NOT_FOUND"
   },
   {
-    "name": "__global$1"
+    "name": "__extends$1"
+  },
+  {
+    "name": "__extends$10"
+  },
+  {
+    "name": "__extends$11"
+  },
+  {
+    "name": "__extends$12"
+  },
+  {
+    "name": "__extends$13"
+  },
+  {
+    "name": "__extends$14"
+  },
+  {
+    "name": "__extends$17"
+  },
+  {
+    "name": "__extends$18"
+  },
+  {
+    "name": "__extends$19"
+  },
+  {
+    "name": "__extends$2"
+  },
+  {
+    "name": "__extends$20"
   },
   {
     "name": "__read"
   },
-  {
-    "name": "__self$1"
-  },
   {
     "name": "__spread"
   },
-  {
-    "name": "__window$1"
-  },
   {
     "name": "_currentInjector"
   },
   {
-    "name": "_root"
+    "name": "config"
   },
   {
     "name": "couldBeInjectableType"
@@ -95,6 +155,15 @@
   {
     "name": "defineInjector"
   },
+  {
+    "name": "empty"
+  },
+  {
+    "name": "errorObject"
+  },
+  {
+    "name": "flattenUnsubscriptionErrors"
+  },
   {
     "name": "forwardRef"
   },
@@ -105,7 +174,10 @@
     "name": "getNullInjector"
   },
   {
-    "name": "getSymbolObservable"
+    "name": "getPromiseCtor"
+  },
+  {
+    "name": "getSymbolIterator$1"
   },
   {
     "name": "hasDeps"
@@ -122,12 +194,21 @@
   {
     "name": "injectableDefRecord"
   },
+  {
+    "name": "isArray"
+  },
   {
     "name": "isExistingProvider"
   },
   {
     "name": "isFactoryProvider"
   },
+  {
+    "name": "isFunction"
+  },
+  {
+    "name": "isObject"
+  },
   {
     "name": "isTypeProvider"
   },
@@ -143,12 +224,30 @@
   {
     "name": "makeRecord"
   },
+  {
+    "name": "nextHandle"
+  },
+  {
+    "name": "noop"
+  },
+  {
+    "name": "observable"
+  },
+  {
+    "name": "pipeFromArray"
+  },
   {
     "name": "providerToRecord"
   },
   {
     "name": "resolveForwardRef"
   },
+  {
+    "name": "runIfPresent"
+  },
+  {
+    "name": "rxSubscriber"
+  },
   {
     "name": "setCurrentInjector"
   },
@@ -156,6 +255,15 @@
     "name": "stringify"
   },
   {
-    "name": "symbolIteratorPonyfill"
+    "name": "tasksByHandle"
+  },
+  {
+    "name": "toSubscriber"
+  },
+  {
+    "name": "tryCatch"
+  },
+  {
+    "name": "tryCatcher"
   }
 ]

packages/core/test/linker/query_integration_spec.ts

@@ -10,7 +10,7 @@ import {AfterContentChecked, AfterContentInit, AfterViewChecked, AfterViewInit,
 import {ComponentFixture, TestBed, async} from '@angular/core/testing';
 import {expect} from '@angular/platform-browser/testing/src/matchers';
 
-import {Subject} from 'rxjs/Subject';
+import {Subject} from 'rxjs';
 
 import {stringify} from '../../src/util';
 

packages/core/test/util/lang_spec.ts

@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 import {isObservable, isPromise} from '@angular/core/src/util/lang';
-import {of } from 'rxjs/observable/of';
+import {of } from 'rxjs';
 
 {
   describe('isPromise', () => {

packages/core/testing/rollup.config.js

@@ -11,8 +11,7 @@ const sourcemaps = require('rollup-plugin-sourcemaps');
 
 const globals = {
   '@angular/core': 'ng.core',
-  'rxjs/Observable': 'Rx',
-  'rxjs/Subject': 'Rx',
+  'rxjs': 'rxjs',
 };
 
 module.exports = {