cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(forms): fix SelectControlValueAccessor not to call onChange twice

Browse Source 
Closes #5969
This commit is contained in:
vsavkin 2015-12-16 15:30:29 -08:00 committed by Victor Savkin
parent a038bb9ae3
commit b44d36cf95
2 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
modules/angular2/src/common/forms/directives/select_control_value_accessor.ts
View File

@ -36,11 +36,7 @@ export class NgSelectOption {
*/ */
@Directive({ @Directive({
selector: 'select[ngControl],select[ngFormControl],select[ngModel]', selector: 'select[ngControl],select[ngFormControl],select[ngModel]',
host: { host: {'(input)': 'onChange($event.target.value)', '(blur)': 'onTouched()'},
'(change)': 'onChange($event.target.value)',
'(input)': 'onChange($event.target.value)',
'(blur)': 'onTouched()'
},
bindings: [SELECT_VALUE_ACCESSOR] bindings: [SELECT_VALUE_ACCESSOR]
}) })
export class SelectControlValueAccessor implements ControlValueAccessor { export class SelectControlValueAccessor implements ControlValueAccessor {

2
modules/angular2/test/common/forms/integration_spec.ts
View File

@ -348,7 +348,7 @@ export function main() {
expect(sfOption.nativeElement.selected).toBe(true); expect(sfOption.nativeElement.selected).toBe(true);
select.nativeElement.value = 'NYC'; select.nativeElement.value = 'NYC';
dispatchEvent(select.nativeElement, "change"); dispatchEvent(select.nativeElement, "input");
expect(fixture.debugElement.componentInstance.form.value).toEqual({"city": 'NYC'}); expect(fixture.debugElement.componentInstance.form.value).toEqual({"city": 'NYC'});
expect(sfOption.nativeElement.selected).toBe(false); expect(sfOption.nativeElement.selected).toBe(false);