From b44f7b5e16b6bc2ae7d6a52b04676213c526146a Mon Sep 17 00:00:00 2001 From: JiaLiPassion Date: Sat, 28 Mar 2020 19:26:53 +0900 Subject: [PATCH] fix(zone.js): fix 2 bluebird test cases for each/mapSeries (#36295) `Bluebird.each` and `Bluebird.mapSeries` will accept a callback with `value` parameter, the `value` should be the item in the array, not array itself. For example: ``` const arr = [1, 2]; Bluebird.each(arr, function(value, idx) { console.log(`value: ${value}, idx: ${idx}`); }) ``` the output will be ``` value: 1, idx: 0 value: 2, idx: 1 ``` This PR fix the test cases for `each` and `mapSeries` APIs. PR Close #36295 --- packages/zone.js/test/extra/bluebird.spec.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/zone.js/test/extra/bluebird.spec.ts b/packages/zone.js/test/extra/bluebird.spec.ts index 8e8e5993ff..a7db2845ee 100644 --- a/packages/zone.js/test/extra/bluebird.spec.ts +++ b/packages/zone.js/test/extra/bluebird.spec.ts @@ -283,8 +283,8 @@ describe('bluebird promise', () => { BluebirdPromise .each( BluebirdPromise.map(arr, (item: number) => BluebirdPromise.resolve(item)), - (r: number[], idx: number) => { - expect(r[idx] === arr[idx]); + (r: number, idx: number) => { + expect(r).toBe(arr[idx]); expect(Zone.current.name).toEqual('bluebird'); }) .then((r: any) => { @@ -304,8 +304,8 @@ describe('bluebird promise', () => { BluebirdPromise .mapSeries( BluebirdPromise.map(arr, (item: number) => BluebirdPromise.resolve(item)), - (r: number[], idx: number) => { - expect(r[idx] === arr[idx]); + (r: number, idx: number) => { + expect(r).toBe(arr[idx]); expect(Zone.current.name).toEqual('bluebird'); }) .then((r: any) => {