From b50ed5c22caea9c7fe849fc3f4344bff1b4619c2 Mon Sep 17 00:00:00 2001
From: Keen Yee Liau <kyliau@google.com>
Date: Thu, 23 Jan 2020 12:59:57 -0800
Subject: [PATCH] fix(language-service): Make metadata in Declaration
 non-optional (#34936)

The `metadata` field in `Declaration` should not be optional.

PR Close #34936
---
 packages/language-service/src/diagnostics.ts | 3 ---
 packages/language-service/src/types.ts       | 2 +-
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/packages/language-service/src/diagnostics.ts b/packages/language-service/src/diagnostics.ts
index bf2e365b19..9b38f7b2e4 100644
--- a/packages/language-service/src/diagnostics.ts
+++ b/packages/language-service/src/diagnostics.ts
@@ -96,9 +96,6 @@ export function getDeclarationDiagnostics(
         span: error.span,
       });
     }
-    if (!metadata) {
-      continue;  // declaration is not an Angular directive
-    }
     if (metadata.isComponent) {
       if (!modules.ngModuleByPipeOrDirective.has(declaration.type)) {
         results.push({
diff --git a/packages/language-service/src/types.ts b/packages/language-service/src/types.ts
index e4844f056b..cb349eea4d 100644
--- a/packages/language-service/src/types.ts
+++ b/packages/language-service/src/types.ts
@@ -124,7 +124,7 @@ export interface Declaration {
   /**
    * Reference to the compiler directive metadata for the declaration.
    */
-  readonly metadata?: CompileDirectiveMetadata;
+  readonly metadata: CompileDirectiveMetadata;
 
   /**
    * Error reported trying to get the metadata.