From b6f439d91bfe513e86188ce7bbd38447bb1cd9eb Mon Sep 17 00:00:00 2001 From: ayazhafiz Date: Tue, 10 Sep 2019 11:04:18 -0500 Subject: [PATCH] refactor(language-service): remove unnecessary size check (#32587) Presumably, the size of the results array was checked so that a TS source file wouldn't have to be created if there were no diagnostics. However, it is very likely that a TS program already has the `ts.SourceFile` for file when diagnostics are queried. This removal is just to make the function a minimal amount simpler. PR Close #32587 --- packages/language-service/src/language_service.ts | 3 --- 1 file changed, 3 deletions(-) diff --git a/packages/language-service/src/language_service.ts b/packages/language-service/src/language_service.ts index d9c24d2078..22e72d80cb 100644 --- a/packages/language-service/src/language_service.ts +++ b/packages/language-service/src/language_service.ts @@ -49,9 +49,6 @@ class LanguageServiceImpl implements LanguageService { if (declarations && declarations.length) { results.push(...getDeclarationDiagnostics(declarations, analyzedModules)); } - if (!results.length) { - return []; - } const sourceFile = fileName.endsWith('.ts') ? this.host.getSourceFile(fileName) : undefined; return uniqueBySpan(results).map(d => ngDiagnosticToTsDiagnostic(d, sourceFile)); }