From b7c17ff207d2c7aa2db21dd6c1a6ee8de4571580 Mon Sep 17 00:00:00 2001
From: Paul Gschwendtner <paulgschwendtner@gmail.com>
Date: Tue, 12 Mar 2019 19:44:03 +0100
Subject: [PATCH] ci: run legacy saucelabs for every build (#29255)

Recently we moved the Saucelabs job into a cronjob in order to avoid
heavy flakiness that we experienced due to a Saucelabs connect bug
that has been supposedly fixed by the Saucelabs team (no new version
is released yet though).

Our initial assumption was that we very rarely hit specific browser failures
and can therefore move the Saucelabs tests into a cronjob, but after some
days of having the cronjob, we realized that we actually hit browser-specific
failures quite often and that we should run the tests for every PR (like before)

PR Close #29255
---
 .circleci/config.yml | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/.circleci/config.yml b/.circleci/config.yml
index e17e7dc4c2..804806ca3a 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -209,7 +209,7 @@ jobs:
           path: dist/bin/packages/core/test/bundling/todo/bundle.min.js.br
           destination: core/todo/bundle.br
 
-  test_saucelabs:
+  test_saucelabs_bazel:
     <<: *job_defaults
     # In order to avoid the bottleneck of having a slow host machine, we acquire a better
     # container for this job. This is necessary because we launch a lot of browsers concurrently
@@ -587,6 +587,9 @@ workflows:
       - test_aio:
           requires:
           - setup
+      - legacy-unit-tests-saucelabs:
+          requires:
+          - setup
       - deploy_aio:
           requires:
             - test_aio
@@ -640,6 +643,7 @@ workflows:
             # since the publishing script expects the legacy outputs layout.
             - build-npm-packages
             - build-ivy-npm-packages
+            - legacy-unit-tests-saucelabs
             - legacy-misc-tests
       - material-unit-tests:
           requires:
@@ -648,14 +652,9 @@ workflows:
   saucelabs_tests:
     jobs:
       - setup
-      - test_saucelabs:
+      - test_saucelabs_bazel:
           requires:
             - setup
-      - legacy-unit-tests-saucelabs:
-          # Don't open up multiple saucelabs tunnels at the same
-          # time to minimize flakes
-          requires:
-            - test_saucelabs
     triggers:
       - schedule:
           # Runs the Saucelabs legacy tests every hour. We still want to run Saucelabs