From b800b882241ab461445e72c7c47c67a6390b6d61 Mon Sep 17 00:00:00 2001 From: Pawel Kozlowski Date: Fri, 11 Oct 2019 11:32:48 +0200 Subject: [PATCH] perf(ivy): stricter null checks in setInputsFromAttrs (#33102) PR Close #33102 --- packages/core/src/render3/instructions/shared.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/core/src/render3/instructions/shared.ts b/packages/core/src/render3/instructions/shared.ts index 54198b7031..2ca04d1a48 100644 --- a/packages/core/src/render3/instructions/shared.ts +++ b/packages/core/src/render3/instructions/shared.ts @@ -1091,7 +1091,7 @@ export function resolveDirectives( function instantiateAllDirectives(tView: TView, lView: LView, tNode: TNode) { const start = tNode.directiveStart; const end = tNode.directiveEnd; - if (!tView.firstTemplatePass && start < end) { + if (!tView.firstTemplatePass) { getOrCreateNodeInjectorForNode( tNode as TElementNode | TContainerNode | TElementContainerNode, lView); } @@ -1367,13 +1367,13 @@ function setInputsFromAttrs( } const initialInputs: InitialInputs|null = initialInputData[directiveIndex]; - if (initialInputs) { + if (initialInputs !== null) { const setInput = def.setInput; for (let i = 0; i < initialInputs.length;) { const publicName = initialInputs[i++]; const privateName = initialInputs[i++]; const value = initialInputs[i++]; - if (setInput) { + if (setInput !== null) { def.setInput !(instance, value, publicName, privateName); } else { (instance as any)[privateName] = value;