From b93c1dffa17e4e6900b3ab1b9e554b6da92be0de Mon Sep 17 00:00:00 2001 From: Pete Bacon Darwin Date: Tue, 13 Nov 2018 14:40:54 +0000 Subject: [PATCH] style(ivy): ngcc - fix misspelled method (#26906) PR Close #26906 --- .../src/ngcc/src/packages/dependency_host.ts | 4 +-- .../test/packages/dependency_host_spec.ts | 25 ++++++++++--------- 2 files changed, 15 insertions(+), 14 deletions(-) diff --git a/packages/compiler-cli/src/ngcc/src/packages/dependency_host.ts b/packages/compiler-cli/src/ngcc/src/packages/dependency_host.ts index 9255fd5de0..5c26e34a8b 100644 --- a/packages/compiler-cli/src/ngcc/src/packages/dependency_host.ts +++ b/packages/compiler-cli/src/ngcc/src/packages/dependency_host.ts @@ -28,7 +28,7 @@ export class DependencyHost { from: string, resolved: Set, missing: Set, deepImports: Set, internal: Set = new Set()): void { const fromContents = fs.readFileSync(from, 'utf8'); - if (!this.hasImportOrReeportStatements(fromContents)) { + if (!this.hasImportOrReexportStatements(fromContents)) { return; } @@ -142,7 +142,7 @@ export class DependencyHost { * @returns false if there are definitely no import or re-export statements * in this file, true otherwise. */ - hasImportOrReeportStatements(source: string): boolean { + hasImportOrReexportStatements(source: string): boolean { return /(import|export)\s.+from/.test(source); } } diff --git a/packages/compiler-cli/src/ngcc/test/packages/dependency_host_spec.ts b/packages/compiler-cli/src/ngcc/test/packages/dependency_host_spec.ts index 1542cfea9e..fc19dd07e4 100644 --- a/packages/compiler-cli/src/ngcc/test/packages/dependency_host_spec.ts +++ b/packages/compiler-cli/src/ngcc/test/packages/dependency_host_spec.ts @@ -222,29 +222,30 @@ describe('DependencyHost', () => { } }); - describe('hasImportOrReeportStatements', () => { + describe('hasImportOrReexportStatements', () => { it('should return true if there is an import statement', () => { - expect(host.hasImportOrReeportStatements('import {X} from "some/x";')).toBe(true); - expect(host.hasImportOrReeportStatements('import * as X from "some/x";')).toBe(true); + expect(host.hasImportOrReexportStatements('import {X} from "some/x";')).toBe(true); + expect(host.hasImportOrReexportStatements('import * as X from "some/x";')).toBe(true); expect( - host.hasImportOrReeportStatements('blah blah\n\n import {X} from "some/x";\nblah blah')) + host.hasImportOrReexportStatements('blah blah\n\n import {X} from "some/x";\nblah blah')) .toBe(true); - expect(host.hasImportOrReeportStatements('\t\timport {X} from "some/x";')).toBe(true); + expect(host.hasImportOrReexportStatements('\t\timport {X} from "some/x";')).toBe(true); }); it('should return true if there is a re-export statement', () => { - expect(host.hasImportOrReeportStatements('export {X} from "some/x";')).toBe(true); + expect(host.hasImportOrReexportStatements('export {X} from "some/x";')).toBe(true); expect( - host.hasImportOrReeportStatements('blah blah\n\n export {X} from "some/x";\nblah blah')) + host.hasImportOrReexportStatements('blah blah\n\n export {X} from "some/x";\nblah blah')) .toBe(true); - expect(host.hasImportOrReeportStatements('\t\texport {X} from "some/x";')).toBe(true); - expect(host.hasImportOrReeportStatements( + expect(host.hasImportOrReexportStatements('\t\texport {X} from "some/x";')).toBe(true); + expect(host.hasImportOrReexportStatements( 'blah blah\n\n export * from "@angular/core;\nblah blah')) .toBe(true); }); it('should return false if there is no import nor re-export statement', () => { - expect(host.hasImportOrReeportStatements('blah blah')).toBe(false); - expect(host.hasImportOrReeportStatements('export function moo() {}')).toBe(false); - expect(host.hasImportOrReeportStatements('Some text that happens to include the word import')) + expect(host.hasImportOrReexportStatements('blah blah')).toBe(false); + expect(host.hasImportOrReexportStatements('export function moo() {}')).toBe(false); + expect( + host.hasImportOrReexportStatements('Some text that happens to include the word import')) .toBe(false); }); });