diff --git a/WORKSPACE b/WORKSPACE index f10ddf76a5..e73eddf5b1 100644 --- a/WORKSPACE +++ b/WORKSPACE @@ -3,18 +3,11 @@ workspace(name = "angular") # # Download Bazel toolchain dependencies as needed by build actions # -http_archive( - name = "build_bazel_rules_nodejs", - urls = ["https://github.com/bazelbuild/rules_nodejs/archive/0.12.0.zip"], - strip_prefix = "rules_nodejs-0.12.0", - sha256 = "2977cdbc8ae0eed7d4186385af56a50a3321a549e2136a959998bba89d2edb6e", -) - http_archive( name = "build_bazel_rules_typescript", - url = "https://github.com/bazelbuild/rules_typescript/archive/0.16.2.zip", - strip_prefix = "rules_typescript-0.16.2", - sha256 = "31601b777840fbf600dbd1893ade0d1de37166e7ba52b90735b107cfb67e38c7", + url = "https://github.com/bazelbuild/rules_typescript/archive/0.17.0.zip", + strip_prefix = "rules_typescript-0.17.0", + sha256 = "1626ee2cc9770af6950bfc77dffa027f9aedf330fe2ea2ee7e504428927bd95d", ) load("@build_bazel_rules_typescript//:package.bzl", "rules_typescript_dependencies") rules_typescript_dependencies() @@ -112,18 +105,10 @@ See https://blog.bazel.build/2018/08/22/bazel-homebrew.html """) node_repositories( - package_json = ["//:package.json"], - preserve_symlinks = True, - node_version = "10.9.0", - yarn_version = "1.9.2", - node_repositories = { - "10.9.0-darwin_amd64": ("node-v10.9.0-darwin-x64.tar.gz", "node-v10.9.0-darwin-x64", "3c4fe75dacfcc495a432a7ba2dec9045cff359af2a5d7d0429c84a424ef686fc"), - "10.9.0-linux_amd64": ("node-v10.9.0-linux-x64.tar.xz", "node-v10.9.0-linux-x64", "c5acb8b7055ee0b6ac653dc4e458c5db45348cecc564b388f4ed1def84a329ff"), - "10.9.0-windows_amd64": ("node-v10.9.0-win-x64.zip", "node-v10.9.0-win-x64", "6a75cdbb69d62ed242d6cbf0238a470bcbf628567ee339d4d098a5efcda2401e"), - }, - yarn_repositories = { - "1.9.2": ("yarn-v1.9.2.tar.gz", "yarn-v1.9.2", "3ad69cc7f68159a562c676e21998eb21b44138cae7e8fe0749a7d620cf940204"), - }, + package_json = ["//:package.json"], + preserve_symlinks = True, + node_version = "10.9.0", + yarn_version = "1.9.2", ) load("@io_bazel_rules_go//go:def.bzl", "go_rules_dependencies", "go_register_toolchains") diff --git a/integration/bazel/WORKSPACE b/integration/bazel/WORKSPACE index 9ba1f4a480..ca5bf3f4e7 100644 --- a/integration/bazel/WORKSPACE +++ b/integration/bazel/WORKSPACE @@ -40,16 +40,8 @@ load("@build_bazel_rules_nodejs//:defs.bzl", "check_bazel_version", "node_reposi check_bazel_version("0.17.0") node_repositories( package_json = ["//:package.json"], - node_version = "10.9.0", - yarn_version = "1.9.2", - node_repositories = { - "10.9.0-darwin_amd64": ("node-v10.9.0-darwin-x64.tar.gz", "node-v10.9.0-darwin-x64", "3c4fe75dacfcc495a432a7ba2dec9045cff359af2a5d7d0429c84a424ef686fc"), - "10.9.0-linux_amd64": ("node-v10.9.0-linux-x64.tar.xz", "node-v10.9.0-linux-x64", "c5acb8b7055ee0b6ac653dc4e458c5db45348cecc564b388f4ed1def84a329ff"), - "10.9.0-windows_amd64": ("node-v10.9.0-win-x64.zip", "node-v10.9.0-win-x64", "6a75cdbb69d62ed242d6cbf0238a470bcbf628567ee339d4d098a5efcda2401e"), - }, - yarn_repositories = { - "1.9.2": ("yarn-v1.9.2.tar.gz", "yarn-v1.9.2", "3ad69cc7f68159a562c676e21998eb21b44138cae7e8fe0749a7d620cf940204"), - }, + node_version = "10.9.0", + yarn_version = "1.9.2", ) load("@io_bazel_rules_go//go:def.bzl", "go_rules_dependencies", "go_register_toolchains") diff --git a/integration/bazel/package.json b/integration/bazel/package.json index 8238b46ff5..4c5e98b004 100644 --- a/integration/bazel/package.json +++ b/integration/bazel/package.json @@ -10,10 +10,9 @@ "zone.js": "file:../../node_modules/zone.js" }, "devDependencies": { - "@bazel/typescript": "0.16.2", + "@bazel/typescript": "0.17.0", "@types/jasmine": "file:../../node_modules/@types/jasmine", "@types/source-map": "0.5.1", - "http-server": "0.11.1", "protractor": "file:../../node_modules/protractor", "tsickle": "file:../../node_modules/tsickle", "typescript": "file:../../node_modules/typescript" diff --git a/integration/bazel/src/BUILD.bazel b/integration/bazel/src/BUILD.bazel index 58db2a8ca0..0393127f4f 100644 --- a/integration/bazel/src/BUILD.bazel +++ b/integration/bazel/src/BUILD.bazel @@ -39,6 +39,7 @@ load("@build_bazel_rules_nodejs//:defs.bzl", "nodejs_binary", "rollup_bundle") rollup_bundle( name = "bundle", entry_point = "src/main", + node_modules = "//:node_modules", deps = ["//src"], ) @@ -51,13 +52,13 @@ genrule( cmd = "cp $< $@", ) -nodejs_binary( +load("@build_bazel_rules_nodejs//:defs.bzl", "http_server") + +http_server( name = "prodserver", data = [ "index.html", ":bundle", ":zone.js", ], - entry_point = "http-server/bin/http-server", - templated_args = ["src"], ) diff --git a/integration/bazel/src/hello-world/BUILD.bazel b/integration/bazel/src/hello-world/BUILD.bazel index 2f98d0875b..8b7e1d0a3d 100644 --- a/integration/bazel/src/hello-world/BUILD.bazel +++ b/integration/bazel/src/hello-world/BUILD.bazel @@ -24,6 +24,7 @@ ng_module( ng_package( name = "npm_package", entry_point = "src/hello-world/index.js", + node_modules = "//:node_modules", deps = [":hello-world"], ) diff --git a/integration/bazel/yarn.lock b/integration/bazel/yarn.lock index 88da845c79..dd514f858f 100644 --- a/integration/bazel/yarn.lock +++ b/integration/bazel/yarn.lock @@ -2,9 +2,9 @@ # yarn lockfile v1 -"@bazel/typescript@0.16.2": +"@bazel/typescript@github:bazelbuild/rules_typescript#87d892be147b66e5668ba14f89ef5df8259de102": version "0.16.2" - resolved "https://registry.yarnpkg.com/@bazel/typescript/-/typescript-0.16.2.tgz#42474e029b0c6fa42a058fc86e2f593b7a367d56" + resolved "https://codeload.github.com/bazelbuild/rules_typescript/tar.gz/87d892be147b66e5668ba14f89ef5df8259de102" dependencies: protobufjs "5.0.0" tsutils "2.20.0" @@ -91,10 +91,6 @@ assert-plus@1.0.0, assert-plus@^1.0.0: version "1.0.0" resolved "https://registry.yarnpkg.com/assert-plus/-/assert-plus-1.0.0.tgz#f12e0f3c5d77b0b1cdd9146942e4e96c1e4dd525" -async@^1.5.2: - version "1.5.2" - resolved "https://registry.yarnpkg.com/async/-/async-1.5.2.tgz#ec6a61ae56480c0c3cb241c95618e20892f9672a" - asynckit@^0.4.0: version "0.4.0" resolved "https://registry.yarnpkg.com/asynckit/-/asynckit-0.4.0.tgz#c79ed97f7f34cb8f2ba1bc9790bcc366474b4b79" @@ -174,10 +170,6 @@ code-point-at@^1.0.0: version "1.1.0" resolved "https://registry.yarnpkg.com/code-point-at/-/code-point-at-1.1.0.tgz#0d070b4d043a5bea33a2f1a40e2edb3d9a4ccf77" -colors@1.0.3: - version "1.0.3" - resolved "https://registry.yarnpkg.com/colors/-/colors-1.0.3.tgz#0433f44d809680fdeb60ed260f1b0c262e82a40b" - colour@~0.7.1: version "0.7.1" resolved "https://registry.yarnpkg.com/colour/-/colour-0.7.1.tgz#9cb169917ec5d12c0736d3e8685746df1cadf778" @@ -196,28 +188,18 @@ core-util-is@1.0.2: version "1.0.2" resolved "https://registry.yarnpkg.com/core-util-is/-/core-util-is-1.0.2.tgz#b5fd54220aa2bc5ab57aab7140c940754503c1a7" -corser@~2.0.0: - version "2.0.1" - resolved "https://registry.yarnpkg.com/corser/-/corser-2.0.1.tgz#8eda252ecaab5840dcd975ceb90d9370c819ff87" - dashdash@^1.12.0: version "1.14.1" resolved "https://registry.yarnpkg.com/dashdash/-/dashdash-1.14.1.tgz#853cfa0f7cbe2fed5de20326b8dd581035f6e2f0" dependencies: assert-plus "^1.0.0" -debug@2, debug@^2.2.0: +debug@2: version "2.6.9" resolved "https://registry.yarnpkg.com/debug/-/debug-2.6.9.tgz#5d128515df134ff327e90a4c93f4e077a536341f" dependencies: ms "2.0.0" -debug@^3.1.0: - version "3.1.0" - resolved "https://registry.yarnpkg.com/debug/-/debug-3.1.0.tgz#5bb5a0672628b64149566ba16819e61518c67261" - dependencies: - ms "2.0.0" - decamelize@^1.1.1: version "1.2.0" resolved "https://registry.yarnpkg.com/decamelize/-/decamelize-1.2.0.tgz#f6534d15148269b20352e7bee26f501f9a191290" @@ -249,23 +231,10 @@ ecc-jsbn@~0.1.1: jsbn "~0.1.0" safer-buffer "^2.1.0" -ecstatic@^3.0.0: - version "3.2.1" - resolved "https://registry.yarnpkg.com/ecstatic/-/ecstatic-3.2.1.tgz#1196a74d63d71d28dea807ed2b6183062671a206" - dependencies: - he "^1.1.1" - mime "^1.6.0" - minimist "^1.1.0" - url-join "^2.0.5" - escape-string-regexp@^1.0.2: version "1.0.5" resolved "https://registry.yarnpkg.com/escape-string-regexp/-/escape-string-regexp-1.0.5.tgz#1b61c0562190a8dff6ae3bb2cf0200ca130b86d4" -eventemitter3@^3.0.0: - version "3.1.0" - resolved "https://registry.yarnpkg.com/eventemitter3/-/eventemitter3-3.1.0.tgz#090b4d6cdbd645ed10bf750d4b5407942d7ba163" - exit@^0.1.2: version "0.1.2" resolved "https://registry.yarnpkg.com/exit/-/exit-0.1.2.tgz#0632638f8d877cc82107d30a0fff1a17cba1cd0c" @@ -290,12 +259,6 @@ fast-json-stable-stringify@^2.0.0: version "2.0.0" resolved "https://registry.yarnpkg.com/fast-json-stable-stringify/-/fast-json-stable-stringify-2.0.0.tgz#d5142c0caee6b1189f87d3a76111064f86c8bbf2" -follow-redirects@^1.0.0: - version "1.5.6" - resolved "https://registry.yarnpkg.com/follow-redirects/-/follow-redirects-1.5.6.tgz#44eb4fe1981dff25e2bd86b7d4033abcdb81e965" - dependencies: - debug "^3.1.0" - forever-agent@~0.6.1: version "0.6.1" resolved "https://registry.yarnpkg.com/forever-agent/-/forever-agent-0.6.1.tgz#fbc71f0c41adeb37f96c577ad1ed42d8fdacca91" @@ -367,31 +330,6 @@ has-ansi@^2.0.0: dependencies: ansi-regex "^2.0.0" -he@^1.1.1: - version "1.1.1" - resolved "https://registry.yarnpkg.com/he/-/he-1.1.1.tgz#93410fd21b009735151f8868c2f271f3427e23fd" - -http-proxy@^1.8.1: - version "1.17.0" - resolved "https://registry.yarnpkg.com/http-proxy/-/http-proxy-1.17.0.tgz#7ad38494658f84605e2f6db4436df410f4e5be9a" - dependencies: - eventemitter3 "^3.0.0" - follow-redirects "^1.0.0" - requires-port "^1.0.0" - -http-server@0.11.1: - version "0.11.1" - resolved "https://registry.yarnpkg.com/http-server/-/http-server-0.11.1.tgz#2302a56a6ffef7f9abea0147d838a5e9b6b6a79b" - dependencies: - colors "1.0.3" - corser "~2.0.0" - ecstatic "^3.0.0" - http-proxy "^1.8.1" - opener "~1.4.0" - optimist "0.6.x" - portfinder "^1.0.13" - union "~0.4.3" - http-signature@~1.2.0: version "1.2.0" resolved "https://registry.yarnpkg.com/http-signature/-/http-signature-1.2.0.tgz#9aecd925114772f3d95b65a60abb8f7c18fbace1" @@ -524,10 +462,6 @@ mime-types@^2.1.12, mime-types@~2.1.19: dependencies: mime-db "~1.35.0" -mime@^1.6.0: - version "1.6.0" - resolved "https://registry.yarnpkg.com/mime/-/mime-1.6.0.tgz#32cd9e5c64553bd58d19a568af452acff04981b1" - "minimatch@2 || 3", minimatch@^3.0.4: version "3.0.4" resolved "https://registry.yarnpkg.com/minimatch/-/minimatch-3.0.4.tgz#5166e286457f03306064be5497e8dbb0c3d32083" @@ -538,7 +472,7 @@ minimist@0.0.8: version "0.0.8" resolved "https://registry.yarnpkg.com/minimist/-/minimist-0.0.8.tgz#857fcabfc3397d2625b8228262e86aa7a011b05d" -minimist@^1.1.0, minimist@^1.2.0: +minimist@^1.2.0: version "1.2.0" resolved "https://registry.yarnpkg.com/minimist/-/minimist-1.2.0.tgz#a35008b20f41383eec1fb914f4cd5df79a264284" @@ -546,7 +480,7 @@ minimist@~0.0.1: version "0.0.10" resolved "https://registry.yarnpkg.com/minimist/-/minimist-0.0.10.tgz#de3f98543dbf96082be48ad1a0c7cda836301dcf" -mkdirp@0.5.x, mkdirp@^0.5.1: +mkdirp@^0.5.1: version "0.5.1" resolved "https://registry.yarnpkg.com/mkdirp/-/mkdirp-0.5.1.tgz#30057438eac6cf7f8c4767f38648d6697d75c903" dependencies: @@ -574,11 +508,7 @@ once@^1.3.0: dependencies: wrappy "1" -opener@~1.4.0: - version "1.4.3" - resolved "https://registry.yarnpkg.com/opener/-/opener-1.4.3.tgz#5c6da2c5d7e5831e8ffa3964950f8d6674ac90b8" - -optimist@0.6.x, optimist@~0.6.0: +optimist@~0.6.0: version "0.6.1" resolved "https://registry.yarnpkg.com/optimist/-/optimist-0.6.1.tgz#da3ea74686fa21a19a111c326e90eb15a0196686" dependencies: @@ -629,14 +559,6 @@ pinkie@^2.0.0: version "2.0.4" resolved "https://registry.yarnpkg.com/pinkie/-/pinkie-2.0.4.tgz#72556b80cfa0d48a974e80e77248e80ed4f7f870" -portfinder@^1.0.13: - version "1.0.17" - resolved "https://registry.yarnpkg.com/portfinder/-/portfinder-1.0.17.tgz#a8a1691143e46c4735edefcf4fbcccedad26456a" - dependencies: - async "^1.5.2" - debug "^2.2.0" - mkdirp "0.5.x" - protobufjs@5.0.0: version "5.0.0" resolved "https://registry.yarnpkg.com/protobufjs/-/protobufjs-5.0.0.tgz#4223063233ea96ac063ca2b554035204db524fa1" @@ -681,10 +603,6 @@ q@^1.4.1: version "1.5.1" resolved "https://registry.yarnpkg.com/q/-/q-1.5.1.tgz#7e32f75b41381291d04611f1bf14109ac00651d7" -qs@~2.3.3: - version "2.3.3" - resolved "https://registry.yarnpkg.com/qs/-/qs-2.3.3.tgz#e9e85adbe75da0bbe4c8e0476a086290f863b404" - qs@~6.5.2: version "6.5.2" resolved "https://registry.yarnpkg.com/qs/-/qs-6.5.2.tgz#cb3ae806e8740444584ef154ce8ee98d403f3e36" @@ -717,10 +635,6 @@ request@^2.87.0: tunnel-agent "^0.6.0" uuid "^3.3.2" -requires-port@^1.0.0: - version "1.0.0" - resolved "https://registry.yarnpkg.com/requires-port/-/requires-port-1.0.0.tgz#925d2601d39ac485e091cf0da5c6e694dc3dcaff" - rimraf@^2.2.8, rimraf@^2.5.2, rimraf@^2.5.4: version "2.6.2" resolved "https://registry.yarnpkg.com/rimraf/-/rimraf-2.6.2.tgz#2ed8150d24a16ea8651e6d6ef0f47c4158ce7a36" @@ -885,22 +799,12 @@ tweetnacl@^0.14.3, tweetnacl@~0.14.0: resolved "https://registry.yarnpkg.com/tweetnacl/-/tweetnacl-0.14.5.tgz#5ae68177f192d4456269d108afa93ff8743f4f64" "typescript@file:../../node_modules/typescript": - version "2.9.2" + version "3.0.1" ultron@1.0.x: version "1.0.2" resolved "https://registry.yarnpkg.com/ultron/-/ultron-1.0.2.tgz#ace116ab557cd197386a4e88f4685378c8b2e4fa" -union@~0.4.3: - version "0.4.6" - resolved "https://registry.yarnpkg.com/union/-/union-0.4.6.tgz#198fbdaeba254e788b0efcb630bc11f24a2959e0" - dependencies: - qs "~2.3.3" - -url-join@^2.0.5: - version "2.0.5" - resolved "https://registry.yarnpkg.com/url-join/-/url-join-2.0.5.tgz#5af22f18c052a000a48d7b82c5e9c2e2feeda728" - uuid@^3.3.2: version "3.3.2" resolved "https://registry.yarnpkg.com/uuid/-/uuid-3.3.2.tgz#1b4af4955eb3077c501c23872fc6513811587131" diff --git a/modules/benchmarks/src/largetable/render3/BUILD.bazel b/modules/benchmarks/src/largetable/render3/BUILD.bazel index 4e5caf6770..862e857414 100644 --- a/modules/benchmarks/src/largetable/render3/BUILD.bazel +++ b/modules/benchmarks/src/largetable/render3/BUILD.bazel @@ -1,7 +1,6 @@ package(default_visibility = ["//visibility:public"]) -load("//tools:defaults.bzl", "ts_library") -load("//packages/bazel/src:ng_rollup_bundle.bzl", "ng_rollup_bundle") +load("//tools:defaults.bzl", "ng_rollup_bundle", "ts_library") load("//packages/bazel:index.bzl", "protractor_web_test") load("@build_bazel_rules_typescript//:defs.bzl", "ts_devserver") diff --git a/packages/bazel/src/ngc-wrapped/BUILD.bazel b/packages/bazel/src/ngc-wrapped/BUILD.bazel index 5b3f2a7c9d..900d9c8862 100644 --- a/packages/bazel/src/ngc-wrapped/BUILD.bazel +++ b/packages/bazel/src/ngc-wrapped/BUILD.bazel @@ -33,6 +33,7 @@ nodejs_binary( "@build_bazel_rules_typescript//third_party/github.com/bazelbuild/bazel/src/main/protobuf:worker_protocol.proto", ], entry_point = "angular/packages/bazel/src/ngc-wrapped/index.js", + node_modules = "@//:node_modules", visibility = ["//visibility:public"], ) @@ -42,5 +43,6 @@ nodejs_binary( ":ngc_lib", ], entry_point = "angular/packages/bazel/src/ngc-wrapped/index.js/extract_i18n.js", + node_modules = "@//:node_modules", visibility = ["//visibility:public"], ) diff --git a/packages/bazel/test/ng_package/BUILD.bazel b/packages/bazel/test/ng_package/BUILD.bazel index 675b9d96e7..139a50373b 100644 --- a/packages/bazel/test/ng_package/BUILD.bazel +++ b/packages/bazel/test/ng_package/BUILD.bazel @@ -1,5 +1,4 @@ -load("//tools:defaults.bzl", "ts_library") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test", "nodejs_binary") +load("//tools:defaults.bzl", "jasmine_node_test", "nodejs_binary", "ts_library") exports_files(["package.json"]) diff --git a/packages/bazel/test/ngc-wrapped/BUILD.bazel b/packages/bazel/test/ngc-wrapped/BUILD.bazel index 6fcd11080e..0b05bb9da7 100644 --- a/packages/bazel/test/ngc-wrapped/BUILD.bazel +++ b/packages/bazel/test/ngc-wrapped/BUILD.bazel @@ -1,5 +1,4 @@ -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") -load("@build_bazel_rules_typescript//:defs.bzl", "ts_library") +load("//tools:defaults.bzl", "jasmine_node_test", "ts_library") ts_library( name = "ngc_test_lib", diff --git a/packages/bazel/test/protractor-2/BUILD.bazel b/packages/bazel/test/protractor-2/BUILD.bazel index 2a0c311af9..8fdea7219e 100644 --- a/packages/bazel/test/protractor-2/BUILD.bazel +++ b/packages/bazel/test/protractor-2/BUILD.bazel @@ -19,6 +19,7 @@ ts_devserver( rollup_bundle( name = "bundle", entry_point = "packages/bazel/test/protractor-2/app", + node_modules = "//:node_modules", deps = [":app"], ) diff --git a/packages/common/http/test/BUILD.bazel b/packages/common/http/test/BUILD.bazel index 3f01fc2c37..911051c827 100644 --- a/packages/common/http/test/BUILD.bazel +++ b/packages/common/http/test/BUILD.bazel @@ -1,5 +1,4 @@ -load("//tools:defaults.bzl", "ts_library", "ts_web_test_suite") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") +load("//tools:defaults.bzl", "jasmine_node_test", "ts_library", "ts_web_test_suite") ts_library( name = "test_lib", diff --git a/packages/common/test/BUILD.bazel b/packages/common/test/BUILD.bazel index 268d0a8bfc..d24cf87ca5 100644 --- a/packages/common/test/BUILD.bazel +++ b/packages/common/test/BUILD.bazel @@ -1,5 +1,4 @@ -load("//tools:defaults.bzl", "ts_library", "ts_web_test_suite") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") +load("//tools:defaults.bzl", "jasmine_node_test", "ts_library", "ts_web_test_suite") ts_library( name = "test_lib", diff --git a/packages/compiler-cli/integrationtest/bazel/injectable_def/app/BUILD.bazel b/packages/compiler-cli/integrationtest/bazel/injectable_def/app/BUILD.bazel index ec996eb8c1..79eced7c34 100644 --- a/packages/compiler-cli/integrationtest/bazel/injectable_def/app/BUILD.bazel +++ b/packages/compiler-cli/integrationtest/bazel/injectable_def/app/BUILD.bazel @@ -1,7 +1,6 @@ package(default_visibility = ["//visibility:public"]) load("//tools:defaults.bzl", "ng_module", "ts_library") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") ng_module( name = "app", diff --git a/packages/compiler-cli/integrationtest/bazel/injectable_def/app/test/BUILD.bazel b/packages/compiler-cli/integrationtest/bazel/injectable_def/app/test/BUILD.bazel index 5e4bb4bd12..765d930b39 100644 --- a/packages/compiler-cli/integrationtest/bazel/injectable_def/app/test/BUILD.bazel +++ b/packages/compiler-cli/integrationtest/bazel/injectable_def/app/test/BUILD.bazel @@ -1,7 +1,6 @@ package(default_visibility = ["//visibility:public"]) -load("//tools:defaults.bzl", "ts_library") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") +load("//tools:defaults.bzl", "jasmine_node_test", "ts_library") ts_library( name = "test_lib", diff --git a/packages/compiler-cli/integrationtest/bazel/injector_def/ivy_build/app/test/BUILD.bazel b/packages/compiler-cli/integrationtest/bazel/injector_def/ivy_build/app/test/BUILD.bazel index 1d89f70765..076f0ef754 100644 --- a/packages/compiler-cli/integrationtest/bazel/injector_def/ivy_build/app/test/BUILD.bazel +++ b/packages/compiler-cli/integrationtest/bazel/injector_def/ivy_build/app/test/BUILD.bazel @@ -1,7 +1,6 @@ package(default_visibility = ["//visibility:public"]) -load("//tools:defaults.bzl", "ts_library") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") +load("//tools:defaults.bzl", "jasmine_node_test", "ts_library") ts_library( name = "test_lib", diff --git a/packages/compiler-cli/integrationtest/bazel/ng_module/BUILD.bazel b/packages/compiler-cli/integrationtest/bazel/ng_module/BUILD.bazel index c411ec594a..d071b5e5cb 100644 --- a/packages/compiler-cli/integrationtest/bazel/ng_module/BUILD.bazel +++ b/packages/compiler-cli/integrationtest/bazel/ng_module/BUILD.bazel @@ -16,7 +16,7 @@ extract_flat_module_index( deps = [":test_module"], ) -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") +load("//tools:defaults.bzl", "jasmine_node_test") jasmine_node_test( name = "test", diff --git a/packages/compiler-cli/src/ngcc/BUILD.bazel b/packages/compiler-cli/src/ngcc/BUILD.bazel index 9b69823c82..4281593b00 100644 --- a/packages/compiler-cli/src/ngcc/BUILD.bazel +++ b/packages/compiler-cli/src/ngcc/BUILD.bazel @@ -1,7 +1,6 @@ package(default_visibility = ["//visibility:public"]) -load("//tools:defaults.bzl", "ts_library") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") +load("//tools:defaults.bzl", "jasmine_node_test", "ts_library") ts_library( name = "ngcc", diff --git a/packages/compiler-cli/src/ngcc/test/BUILD.bazel b/packages/compiler-cli/src/ngcc/test/BUILD.bazel index 5f534a5662..90335b3294 100644 --- a/packages/compiler-cli/src/ngcc/test/BUILD.bazel +++ b/packages/compiler-cli/src/ngcc/test/BUILD.bazel @@ -1,7 +1,6 @@ package(default_visibility = ["//visibility:public"]) -load("//tools:defaults.bzl", "ts_library") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") +load("//tools:defaults.bzl", "jasmine_node_test", "ts_library") ts_library( name = "test_lib", diff --git a/packages/compiler-cli/src/ngtsc/annotations/test/BUILD.bazel b/packages/compiler-cli/src/ngtsc/annotations/test/BUILD.bazel index 156ce95512..700eaf74c5 100644 --- a/packages/compiler-cli/src/ngtsc/annotations/test/BUILD.bazel +++ b/packages/compiler-cli/src/ngtsc/annotations/test/BUILD.bazel @@ -1,7 +1,6 @@ package(default_visibility = ["//visibility:public"]) -load("//tools:defaults.bzl", "ts_library") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") +load("//tools:defaults.bzl", "jasmine_node_test", "ts_library") ts_library( name = "test_lib", diff --git a/packages/compiler-cli/src/ngtsc/metadata/test/BUILD.bazel b/packages/compiler-cli/src/ngtsc/metadata/test/BUILD.bazel index 65474c8342..93e7193cb3 100644 --- a/packages/compiler-cli/src/ngtsc/metadata/test/BUILD.bazel +++ b/packages/compiler-cli/src/ngtsc/metadata/test/BUILD.bazel @@ -1,7 +1,6 @@ package(default_visibility = ["//visibility:public"]) -load("//tools:defaults.bzl", "ts_library") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") +load("//tools:defaults.bzl", "jasmine_node_test", "ts_library") ts_library( name = "test_lib", diff --git a/packages/compiler-cli/src/ngtsc/testing/BUILD.bazel b/packages/compiler-cli/src/ngtsc/testing/BUILD.bazel index 9396da86ca..2db1586347 100644 --- a/packages/compiler-cli/src/ngtsc/testing/BUILD.bazel +++ b/packages/compiler-cli/src/ngtsc/testing/BUILD.bazel @@ -1,7 +1,6 @@ package(default_visibility = ["//visibility:public"]) load("//tools:defaults.bzl", "ts_library") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") ts_library( name = "testing", diff --git a/packages/compiler-cli/src/ngtsc/util/test/BUILD.bazel b/packages/compiler-cli/src/ngtsc/util/test/BUILD.bazel index 21637b1b03..4be4b05259 100644 --- a/packages/compiler-cli/src/ngtsc/util/test/BUILD.bazel +++ b/packages/compiler-cli/src/ngtsc/util/test/BUILD.bazel @@ -1,7 +1,6 @@ package(default_visibility = ["//visibility:public"]) -load("//tools:defaults.bzl", "ts_library") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") +load("//tools:defaults.bzl", "jasmine_node_test", "ts_library") ts_library( name = "test_lib", diff --git a/packages/compiler-cli/test/BUILD.bazel b/packages/compiler-cli/test/BUILD.bazel index 3bb2066914..75cacf05ed 100644 --- a/packages/compiler-cli/test/BUILD.bazel +++ b/packages/compiler-cli/test/BUILD.bazel @@ -1,5 +1,4 @@ -load("//tools:defaults.bzl", "ts_library") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") +load("//tools:defaults.bzl", "jasmine_node_test", "ts_library") # Uses separate test rules to allow the tests to run in parallel diff --git a/packages/compiler-cli/test/compliance/BUILD.bazel b/packages/compiler-cli/test/compliance/BUILD.bazel index b49764a597..5a8496398e 100644 --- a/packages/compiler-cli/test/compliance/BUILD.bazel +++ b/packages/compiler-cli/test/compliance/BUILD.bazel @@ -1,5 +1,4 @@ -load("//tools:defaults.bzl", "ts_library") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") +load("//tools:defaults.bzl", "jasmine_node_test", "ts_library") ts_library( name = "test_lib", diff --git a/packages/compiler-cli/test/diagnostics/BUILD.bazel b/packages/compiler-cli/test/diagnostics/BUILD.bazel index fc35f2e5b5..6c7d83aabb 100644 --- a/packages/compiler-cli/test/diagnostics/BUILD.bazel +++ b/packages/compiler-cli/test/diagnostics/BUILD.bazel @@ -1,5 +1,4 @@ -load("//tools:defaults.bzl", "ts_library") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") +load("//tools:defaults.bzl", "jasmine_node_test", "ts_library") ts_library( name = "mocks", diff --git a/packages/compiler-cli/test/metadata/BUILD.bazel b/packages/compiler-cli/test/metadata/BUILD.bazel index a54dd2c69d..9152e2dda1 100644 --- a/packages/compiler-cli/test/metadata/BUILD.bazel +++ b/packages/compiler-cli/test/metadata/BUILD.bazel @@ -1,5 +1,4 @@ -load("//tools:defaults.bzl", "ts_library") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") +load("//tools:defaults.bzl", "jasmine_node_test", "ts_library") ts_library( name = "test_lib", diff --git a/packages/compiler-cli/test/ngcc/BUILD.bazel b/packages/compiler-cli/test/ngcc/BUILD.bazel index 9745a3f6bd..d80c1b7c10 100644 --- a/packages/compiler-cli/test/ngcc/BUILD.bazel +++ b/packages/compiler-cli/test/ngcc/BUILD.bazel @@ -1,5 +1,4 @@ -load("//tools:defaults.bzl", "ts_library") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") +load("//tools:defaults.bzl", "jasmine_node_test", "ts_library") # Integration tests ts_library( diff --git a/packages/compiler-cli/test/ngtsc/BUILD.bazel b/packages/compiler-cli/test/ngtsc/BUILD.bazel index dfa3f80bfa..96fa99c5ec 100644 --- a/packages/compiler-cli/test/ngtsc/BUILD.bazel +++ b/packages/compiler-cli/test/ngtsc/BUILD.bazel @@ -1,5 +1,4 @@ -load("//tools:defaults.bzl", "ts_library") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") +load("//tools:defaults.bzl", "jasmine_node_test", "ts_library") ts_library( name = "ngtsc_lib", diff --git a/packages/compiler-cli/test/transformers/BUILD.bazel b/packages/compiler-cli/test/transformers/BUILD.bazel index 2b50f52676..c964caf054 100644 --- a/packages/compiler-cli/test/transformers/BUILD.bazel +++ b/packages/compiler-cli/test/transformers/BUILD.bazel @@ -1,5 +1,4 @@ -load("//tools:defaults.bzl", "ts_library") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") +load("//tools:defaults.bzl", "jasmine_node_test", "ts_library") ts_library( name = "test_lib", diff --git a/packages/compiler/test/BUILD.bazel b/packages/compiler/test/BUILD.bazel index 93f48479e9..dfdd5492df 100644 --- a/packages/compiler/test/BUILD.bazel +++ b/packages/compiler/test/BUILD.bazel @@ -1,5 +1,4 @@ -load("//tools:defaults.bzl", "ts_library", "ts_web_test_suite") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") +load("//tools:defaults.bzl", "jasmine_node_test", "ts_library", "ts_web_test_suite") # Test that should only be run in node NODE_ONLY = [ diff --git a/packages/compiler/test/render3/BUILD.bazel b/packages/compiler/test/render3/BUILD.bazel index 48af3bc592..a542f6ca31 100644 --- a/packages/compiler/test/render3/BUILD.bazel +++ b/packages/compiler/test/render3/BUILD.bazel @@ -1,5 +1,4 @@ -load("//tools:defaults.bzl", "ts_library") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") +load("//tools:defaults.bzl", "jasmine_node_test", "ts_library") ts_library( name = "test_lib", diff --git a/packages/core/src/render3/ng_dev_mode.ts b/packages/core/src/render3/ng_dev_mode.ts index cdf56d98b6..9606a94ce0 100644 --- a/packages/core/src/render3/ng_dev_mode.ts +++ b/packages/core/src/render3/ng_dev_mode.ts @@ -34,15 +34,8 @@ declare global { declare let global: any; -// NOTE: The order here matters: Checking window, then global, then self is important. -// checking them in another order can result in errors in some Node environments. -const __global: {ngDevMode: NgDevModePerfCounters | boolean} = - typeof window != 'undefined' && window || typeof global != 'undefined' && global || - typeof self != 'undefined' && self; - export function ngDevModeResetPerfCounters(): NgDevModePerfCounters { - // Make sure to refer to ngDevMode as ['ngDevMode'] for clousre. - return __global['ngDevMode'] = { + const newCounters: NgDevModePerfCounters = { firstTemplatePass: 0, tNode: 0, tView: 0, @@ -64,6 +57,21 @@ export function ngDevModeResetPerfCounters(): NgDevModePerfCounters { rendererRemoveNode: 0, rendererCreateComment: 0, }; + // NOTE: Under Ivy we may have both window & global defined in the Node + // environment since ensureDocument() in render3.ts sets global.window. + if (typeof window != 'undefined') { + // Make sure to refer to ngDevMode as ['ngDevMode'] for closure. + (window as any)['ngDevMode'] = newCounters; + } + if (typeof global != 'undefined') { + // Make sure to refer to ngDevMode as ['ngDevMode'] for closure. + (global as any)['ngDevMode'] = newCounters; + } + if (typeof self != 'undefined') { + // Make sure to refer to ngDevMode as ['ngDevMode'] for closure. + (self as any)['ngDevMode'] = newCounters; + } + return newCounters; } /** @@ -75,6 +83,5 @@ export function ngDevModeResetPerfCounters(): NgDevModePerfCounters { * as much early warning and errors as possible. */ if (typeof ngDevMode === 'undefined' || ngDevMode) { - // Make sure to refer to ngDevMode as ['ngDevMode'] for clousre. - __global['ngDevMode'] = ngDevModeResetPerfCounters(); + ngDevModeResetPerfCounters(); } diff --git a/packages/core/test/BUILD.bazel b/packages/core/test/BUILD.bazel index 51c52457b1..5f2b26d788 100644 --- a/packages/core/test/BUILD.bazel +++ b/packages/core/test/BUILD.bazel @@ -1,7 +1,6 @@ package(default_visibility = ["//visibility:public"]) -load("//tools:defaults.bzl", "ts_library", "ts_web_test_suite") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") +load("//tools:defaults.bzl", "jasmine_node_test", "ts_library", "ts_web_test_suite") ts_library( name = "test_lib", diff --git a/packages/core/test/bundling/hello_world/BUILD.bazel b/packages/core/test/bundling/hello_world/BUILD.bazel index 00cdd93ec3..e577e4ba01 100644 --- a/packages/core/test/bundling/hello_world/BUILD.bazel +++ b/packages/core/test/bundling/hello_world/BUILD.bazel @@ -1,9 +1,7 @@ package(default_visibility = ["//visibility:public"]) -load("//tools:defaults.bzl", "ng_module", "ts_library") +load("//tools:defaults.bzl", "jasmine_node_test", "ng_module", "ng_rollup_bundle", "ts_library") load("//tools/symbol-extractor:index.bzl", "js_expected_symbol_test") -load("//packages/bazel/src:ng_rollup_bundle.bzl", "ng_rollup_bundle") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") load("//tools/http-server:http_server.bzl", "http_server") ng_module( diff --git a/packages/core/test/bundling/hello_world_i18n/BUILD.bazel b/packages/core/test/bundling/hello_world_i18n/BUILD.bazel index 5dcf0fe0de..7ec09627a9 100644 --- a/packages/core/test/bundling/hello_world_i18n/BUILD.bazel +++ b/packages/core/test/bundling/hello_world_i18n/BUILD.bazel @@ -1,7 +1,6 @@ package(default_visibility = ["//visibility:public"]) -load("//tools:defaults.bzl", "ivy_ng_module", "ts_library") -load("//packages/bazel/src:ng_rollup_bundle.bzl", "ng_rollup_bundle") +load("//tools:defaults.bzl", "ivy_ng_module", "ng_rollup_bundle", "ts_library") load("//tools/http-server:http_server.bzl", "http_server") ivy_ng_module( diff --git a/packages/core/test/bundling/hello_world_r2/BUILD.bazel b/packages/core/test/bundling/hello_world_r2/BUILD.bazel index 330f823f1c..25d087e7c5 100644 --- a/packages/core/test/bundling/hello_world_r2/BUILD.bazel +++ b/packages/core/test/bundling/hello_world_r2/BUILD.bazel @@ -1,9 +1,7 @@ package(default_visibility = ["//visibility:public"]) -load("//tools:defaults.bzl", "ng_module", "ts_library") +load("//tools:defaults.bzl", "jasmine_node_test", "ng_module", "ng_rollup_bundle", "ts_library") load("//tools/symbol-extractor:index.bzl", "js_expected_symbol_test") -load("//packages/bazel/src:ng_rollup_bundle.bzl", "ng_rollup_bundle") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") load("//tools/http-server:http_server.bzl", "http_server") ng_module( diff --git a/packages/core/test/bundling/injection/BUILD.bazel b/packages/core/test/bundling/injection/BUILD.bazel index 39112c77ce..0609034d56 100644 --- a/packages/core/test/bundling/injection/BUILD.bazel +++ b/packages/core/test/bundling/injection/BUILD.bazel @@ -1,9 +1,7 @@ package(default_visibility = ["//visibility:public"]) -load("//tools:defaults.bzl", "ts_library") +load("//tools:defaults.bzl", "jasmine_node_test", "ng_rollup_bundle", "ts_library") load("//tools/symbol-extractor:index.bzl", "js_expected_symbol_test") -load("//packages/bazel/src:ng_rollup_bundle.bzl", "ng_rollup_bundle") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") ts_library( name = "injection", diff --git a/packages/core/test/bundling/todo/BUILD.bazel b/packages/core/test/bundling/todo/BUILD.bazel index cac0c960a1..06e5e789e5 100644 --- a/packages/core/test/bundling/todo/BUILD.bazel +++ b/packages/core/test/bundling/todo/BUILD.bazel @@ -1,10 +1,8 @@ package(default_visibility = ["//visibility:public"]) -load("//tools:defaults.bzl", "ng_module", "ts_library") +load("//tools:defaults.bzl", "jasmine_node_test", "ng_module", "ng_rollup_bundle", "ts_library") load("//tools/http-server:http_server.bzl", "http_server") load("//tools/symbol-extractor:index.bzl", "js_expected_symbol_test") -load("//packages/bazel/src:ng_rollup_bundle.bzl", "ng_rollup_bundle") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") load("@build_bazel_rules_typescript//:defs.bzl", "ts_devserver") ng_module( diff --git a/packages/core/test/bundling/todo_r2/BUILD.bazel b/packages/core/test/bundling/todo_r2/BUILD.bazel index b83424c4e1..ed41a02bec 100644 --- a/packages/core/test/bundling/todo_r2/BUILD.bazel +++ b/packages/core/test/bundling/todo_r2/BUILD.bazel @@ -1,10 +1,8 @@ package(default_visibility = ["//visibility:public"]) -load("//tools:defaults.bzl", "ng_module", "ts_library") +load("//tools:defaults.bzl", "jasmine_node_test", "ng_module", "ng_rollup_bundle", "ts_library") load("//tools/http-server:http_server.bzl", "http_server") load("//tools/symbol-extractor:index.bzl", "js_expected_symbol_test") -load("//packages/bazel/src:ng_rollup_bundle.bzl", "ng_rollup_bundle") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") load("@build_bazel_rules_typescript//:defs.bzl", "ts_devserver") ng_module( diff --git a/packages/core/test/render3/BUILD.bazel b/packages/core/test/render3/BUILD.bazel index d3e85704dd..99e41176ba 100644 --- a/packages/core/test/render3/BUILD.bazel +++ b/packages/core/test/render3/BUILD.bazel @@ -1,7 +1,6 @@ package(default_visibility = ["//visibility:public"]) -load("//tools:defaults.bzl", "ts_library", "ts_web_test_suite") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") +load("//tools:defaults.bzl", "jasmine_node_test", "ts_library", "ts_web_test_suite") ts_library( name = "render3_lib", diff --git a/packages/core/test/render3/ivy/BUILD.bazel b/packages/core/test/render3/ivy/BUILD.bazel index dd78fb48fa..c85324afc9 100644 --- a/packages/core/test/render3/ivy/BUILD.bazel +++ b/packages/core/test/render3/ivy/BUILD.bazel @@ -1,7 +1,6 @@ package(default_visibility = ["//visibility:public"]) -load("//tools:defaults.bzl", "ts_library", "ts_web_test_suite") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") +load("//tools:defaults.bzl", "jasmine_node_test", "ts_library", "ts_web_test_suite") ts_library( name = "ivy_lib", diff --git a/packages/elements/schematics/BUILD.bazel b/packages/elements/schematics/BUILD.bazel index 1ab8a09b61..3a3c20fa78 100644 --- a/packages/elements/schematics/BUILD.bazel +++ b/packages/elements/schematics/BUILD.bazel @@ -1,7 +1,6 @@ package(default_visibility = ["//visibility:public"]) load("//tools:defaults.bzl", "npm_package", "ts_library") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") exports_files([ "package.json", diff --git a/packages/elements/schematics/ng-add/BUILD.bazel b/packages/elements/schematics/ng-add/BUILD.bazel index 28bdcb0a2d..337ce46000 100644 --- a/packages/elements/schematics/ng-add/BUILD.bazel +++ b/packages/elements/schematics/ng-add/BUILD.bazel @@ -1,7 +1,6 @@ package(default_visibility = ["//visibility:public"]) -load("//tools:defaults.bzl", "npm_package", "ts_library") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") +load("//tools:defaults.bzl", "jasmine_node_test", "npm_package", "ts_library") ts_library( name = "ng-add", diff --git a/packages/elements/test/BUILD.bazel b/packages/elements/test/BUILD.bazel index ec44be216b..bc912f6f7f 100644 --- a/packages/elements/test/BUILD.bazel +++ b/packages/elements/test/BUILD.bazel @@ -1,6 +1,5 @@ -load("//tools:defaults.bzl", "ts_library") +load("//tools:defaults.bzl", "jasmine_node_test", "ts_library") load("@build_bazel_rules_typescript//:defs.bzl", "ts_web_test_suite") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") ts_library( name = "test_lib", diff --git a/packages/forms/test/BUILD.bazel b/packages/forms/test/BUILD.bazel index 7daeea9391..781b2d4762 100644 --- a/packages/forms/test/BUILD.bazel +++ b/packages/forms/test/BUILD.bazel @@ -1,5 +1,4 @@ -load("//tools:defaults.bzl", "ts_library", "ts_web_test_suite") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") +load("//tools:defaults.bzl", "jasmine_node_test", "ts_library", "ts_web_test_suite") ts_library( name = "test_lib", diff --git a/packages/http/test/BUILD.bazel b/packages/http/test/BUILD.bazel index 05c83ed83a..5778808de0 100644 --- a/packages/http/test/BUILD.bazel +++ b/packages/http/test/BUILD.bazel @@ -1,5 +1,4 @@ -load("//tools:defaults.bzl", "ts_library", "ts_web_test_suite") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") +load("//tools:defaults.bzl", "jasmine_node_test", "ts_library", "ts_web_test_suite") ts_library( name = "test_lib", diff --git a/packages/language-service/bundles/BUILD.bazel b/packages/language-service/bundles/BUILD.bazel index 4a999d2385..dce198a73e 100644 --- a/packages/language-service/bundles/BUILD.bazel +++ b/packages/language-service/bundles/BUILD.bazel @@ -9,6 +9,7 @@ ls_rollup_bundle( "fs": "fs", }, license_banner = "banner.js.txt", + node_modules = "//:node_modules", visibility = ["//packages/language-service:__pkg__"], deps = ["//packages/language-service"], ) diff --git a/packages/language-service/test/BUILD.bazel b/packages/language-service/test/BUILD.bazel index 81d9cd0811..a9c89e1a75 100644 --- a/packages/language-service/test/BUILD.bazel +++ b/packages/language-service/test/BUILD.bazel @@ -1,5 +1,4 @@ -load("//tools:defaults.bzl", "ts_library") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") +load("//tools:defaults.bzl", "jasmine_node_test", "ts_library") ts_library( name = "test_lib", diff --git a/packages/platform-browser-dynamic/test/BUILD.bazel b/packages/platform-browser-dynamic/test/BUILD.bazel index 0abf978379..53273f1b7e 100644 --- a/packages/platform-browser-dynamic/test/BUILD.bazel +++ b/packages/platform-browser-dynamic/test/BUILD.bazel @@ -1,5 +1,4 @@ -load("//tools:defaults.bzl", "ts_library", "ts_web_test_suite") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") +load("//tools:defaults.bzl", "jasmine_node_test", "ts_library", "ts_web_test_suite") ts_library( name = "test_lib", diff --git a/packages/platform-browser/test/BUILD.bazel b/packages/platform-browser/test/BUILD.bazel index 622b9c9edb..051d453b8c 100644 --- a/packages/platform-browser/test/BUILD.bazel +++ b/packages/platform-browser/test/BUILD.bazel @@ -1,5 +1,4 @@ -load("//tools:defaults.bzl", "ts_library", "ts_web_test_suite") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") +load("//tools:defaults.bzl", "jasmine_node_test", "ts_library", "ts_web_test_suite") exports_files([ "browser/static_assets/200.html", diff --git a/packages/platform-server/test/BUILD.bazel b/packages/platform-server/test/BUILD.bazel index 9ab6cbc5dd..c5e582fd03 100644 --- a/packages/platform-server/test/BUILD.bazel +++ b/packages/platform-server/test/BUILD.bazel @@ -1,5 +1,4 @@ -load("//tools:defaults.bzl", "ts_library") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") +load("//tools:defaults.bzl", "jasmine_node_test", "ts_library") ts_library( name = "test_lib", diff --git a/packages/platform-webworker/test/BUILD.bazel b/packages/platform-webworker/test/BUILD.bazel index d0937bdf77..f71440b965 100644 --- a/packages/platform-webworker/test/BUILD.bazel +++ b/packages/platform-webworker/test/BUILD.bazel @@ -1,5 +1,4 @@ -load("//tools:defaults.bzl", "ts_library", "ts_web_test_suite") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") +load("//tools:defaults.bzl", "jasmine_node_test", "ts_library", "ts_web_test_suite") ts_library( name = "test_lib", diff --git a/packages/router/test/BUILD.bazel b/packages/router/test/BUILD.bazel index 7dfa2b62b4..0311351743 100644 --- a/packages/router/test/BUILD.bazel +++ b/packages/router/test/BUILD.bazel @@ -1,5 +1,4 @@ -load("//tools:defaults.bzl", "ts_library", "ts_web_test_suite") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") +load("//tools:defaults.bzl", "jasmine_node_test", "ts_library", "ts_web_test_suite") ts_library( name = "test_lib", diff --git a/packages/router/test/aot_ngsummary_test/BUILD.bazel b/packages/router/test/aot_ngsummary_test/BUILD.bazel index 8b4ab74cdc..8f214fcecb 100644 --- a/packages/router/test/aot_ngsummary_test/BUILD.bazel +++ b/packages/router/test/aot_ngsummary_test/BUILD.bazel @@ -1,6 +1,4 @@ -load("//tools:defaults.bzl", "ts_library", "ts_web_test_suite") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") -load("//tools:defaults.bzl", "ng_module") +load("//tools:defaults.bzl", "jasmine_node_test", "ng_module", "ts_library", "ts_web_test_suite") ng_module( name = "aot_routing_module", diff --git a/packages/service-worker/cli/BUILD.bazel b/packages/service-worker/cli/BUILD.bazel index 089d5b3ced..87f18deb71 100644 --- a/packages/service-worker/cli/BUILD.bazel +++ b/packages/service-worker/cli/BUILD.bazel @@ -1,7 +1,6 @@ package(default_visibility = ["//visibility:public"]) -load("//tools:defaults.bzl", "npm_package", "ts_library") -load("//packages/bazel/src:ng_rollup_bundle.bzl", "ng_rollup_bundle") +load("//tools:defaults.bzl", "ng_rollup_bundle", "ts_library") ts_library( name = "cli", diff --git a/packages/service-worker/test/BUILD.bazel b/packages/service-worker/test/BUILD.bazel index fcf967139b..92ac98953e 100644 --- a/packages/service-worker/test/BUILD.bazel +++ b/packages/service-worker/test/BUILD.bazel @@ -1,5 +1,4 @@ -load("//tools:defaults.bzl", "ts_library", "ts_web_test_suite") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") +load("//tools:defaults.bzl", "jasmine_node_test", "ts_library", "ts_web_test_suite") ts_library( name = "test_lib", diff --git a/packages/service-worker/worker/BUILD.bazel b/packages/service-worker/worker/BUILD.bazel index 121809e63a..a105be7457 100644 --- a/packages/service-worker/worker/BUILD.bazel +++ b/packages/service-worker/worker/BUILD.bazel @@ -1,7 +1,7 @@ package(default_visibility = ["//visibility:public"]) load("@build_bazel_rules_typescript//:defs.bzl", "ts_library") -load("//packages/bazel/src:ng_rollup_bundle.bzl", "ng_rollup_bundle") +load("//tools:defaults.bzl", "ng_rollup_bundle") ts_library( name = "worker", diff --git a/packages/service-worker/worker/test/BUILD.bazel b/packages/service-worker/worker/test/BUILD.bazel index fafb2f5f2d..15b911657e 100644 --- a/packages/service-worker/worker/test/BUILD.bazel +++ b/packages/service-worker/worker/test/BUILD.bazel @@ -1,5 +1,4 @@ -load("//tools:defaults.bzl", "ts_library") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") +load("//tools:defaults.bzl", "jasmine_node_test", "ts_library") ts_library( name = "test_lib", diff --git a/packages/upgrade/test/BUILD.bazel b/packages/upgrade/test/BUILD.bazel index d6fc0c92e7..31825435e0 100644 --- a/packages/upgrade/test/BUILD.bazel +++ b/packages/upgrade/test/BUILD.bazel @@ -1,5 +1,4 @@ -load("//tools:defaults.bzl", "ts_library", "ts_web_test_suite") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") +load("//tools:defaults.bzl", "jasmine_node_test", "ts_library", "ts_web_test_suite") ts_library( name = "test_lib", diff --git a/tools/defaults.bzl b/tools/defaults.bzl index 5bf3c3b1aa..61c9cffd24 100644 --- a/tools/defaults.bzl +++ b/tools/defaults.bzl @@ -1,9 +1,10 @@ """Re-export of some bazel rules with repository-wide defaults.""" -load("@build_bazel_rules_nodejs//:defs.bzl", _npm_package = "npm_package") +load("@build_bazel_rules_nodejs//:defs.bzl", _jasmine_node_test = "jasmine_node_test", _nodejs_binary = "nodejs_binary", _npm_package = "npm_package") load("@build_bazel_rules_typescript//:defs.bzl", _ts_library = "ts_library", _ts_web_test_suite = "ts_web_test_suite") load("//packages/bazel:index.bzl", _ng_module = "ng_module", _ng_package = "ng_package") load("//packages/bazel/src:ng_module.bzl", _internal_global_ng_module = "internal_global_ng_module") +load("//packages/bazel/src:ng_rollup_bundle.bzl", _ng_rollup_bundle = "ng_rollup_bundle") DEFAULT_TSCONFIG_BUILD = "//packages:tsconfig-build.json" DEFAULT_TSCONFIG_TEST = "//packages:tsconfig-test.json" @@ -71,7 +72,7 @@ def ivy_ng_module(name, tsconfig = None, entry_point = None, testonly = False, * entry_point = "public_api.ts" _internal_global_ng_module(name = name, flat_module_out_file = name, tsconfig = tsconfig, entry_point = entry_point, testonly = testonly, **kwargs) -def ng_package(name, readme_md = None, license_banner = None, **kwargs): +def ng_package(name, node_modules = DEFAULT_NODE_MODULES, readme_md = None, license_banner = None, **kwargs): if not readme_md: readme_md = "//packages:README.md" if not license_banner: @@ -82,6 +83,7 @@ def ng_package(name, readme_md = None, license_banner = None, **kwargs): readme_md = readme_md, license_banner = license_banner, replacements = PKG_GROUP_REPLACEMENTS, + node_modules = node_modules, **kwargs ) @@ -116,3 +118,12 @@ def ts_web_test_suite(bootstrap = [], deps = [], **kwargs): ], **kwargs ) + +def nodejs_binary(node_modules = DEFAULT_NODE_MODULES, **kwargs): + _nodejs_binary(node_modules = node_modules, **kwargs) + +def jasmine_node_test(node_modules = DEFAULT_NODE_MODULES, **kwargs): + _jasmine_node_test(node_modules = node_modules, **kwargs) + +def ng_rollup_bundle(node_modules = DEFAULT_NODE_MODULES, **kwargs): + _ng_rollup_bundle(node_modules = node_modules, **kwargs) diff --git a/tools/ng_setup_workspace.bzl b/tools/ng_setup_workspace.bzl index c0337ac420..dda119c261 100644 --- a/tools/ng_setup_workspace.bzl +++ b/tools/ng_setup_workspace.bzl @@ -19,7 +19,7 @@ def ng_setup_workspace(): package_json = "@angular//:package.json", yarn_lock = "@angular//:yarn.lock", data = ["@angular//:tools/yarn/check-yarn.js", "@angular//:tools/postinstall-patches.js"], - node_modules_filegroup = """ + manual_build_file_contents = """package(default_visibility = ["//visibility:public"]) filegroup( name = "node_modules", srcs = glob(["/".join([ diff --git a/tools/symbol-extractor/BUILD.bazel b/tools/symbol-extractor/BUILD.bazel index 4716f25f9c..8f0c061ab8 100644 --- a/tools/symbol-extractor/BUILD.bazel +++ b/tools/symbol-extractor/BUILD.bazel @@ -1,7 +1,6 @@ package(default_visibility = ["//visibility:public"]) -load("//tools:defaults.bzl", "ts_library") -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") +load("//tools:defaults.bzl", "jasmine_node_test", "ts_library") ts_library( name = "lib", diff --git a/tools/symbol-extractor/index.bzl b/tools/symbol-extractor/index.bzl index de5583f760..249e5c8a48 100644 --- a/tools/symbol-extractor/index.bzl +++ b/tools/symbol-extractor/index.bzl @@ -10,7 +10,9 @@ # because it introduces an extra target_bin target. load("@build_bazel_rules_nodejs//internal/node:node.bzl", "nodejs_binary", "nodejs_test") -def js_expected_symbol_test(name, src, golden, **kwargs): +DEFAULT_NODE_MODULES = "@angular_deps//:node_modules" + +def js_expected_symbol_test(name, src, golden, node_modules = DEFAULT_NODE_MODULES, **kwargs): """This test verifies that a set of top level symbols from a javascript file match a gold file. """ all_data = [src, golden] @@ -23,6 +25,7 @@ def js_expected_symbol_test(name, src, golden, **kwargs): data = all_data, entry_point = entry_point, templated_args = ["$(location %s)" % src, "$(location %s)" % golden], + node_modules = node_modules, **kwargs ) @@ -32,5 +35,6 @@ def js_expected_symbol_test(name, src, golden, **kwargs): data = all_data, entry_point = entry_point, templated_args = ["$(location %s)" % src, "$(location %s)" % golden, "--accept"], + node_modules = node_modules, **kwargs ) diff --git a/tools/validate-commit-message/BUILD.bazel b/tools/validate-commit-message/BUILD.bazel index 06b1402f43..51cf06ccbe 100644 --- a/tools/validate-commit-message/BUILD.bazel +++ b/tools/validate-commit-message/BUILD.bazel @@ -1,4 +1,4 @@ -load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") +load("//tools:defaults.bzl", "jasmine_node_test") jasmine_node_test( name = "validate-commit-message",