fix(language-service): The pipe method should not include parentheses (#34485)

PR Close #34485
This commit is contained in:
ivanwonder
2019-12-19 11:10:09 +08:00
committed by Alex Rickabaugh
parent eab7f9f101
commit ba2fd31e62
2 changed files with 17 additions and 1 deletions

View File

@ -469,11 +469,15 @@ class ExpressionVisitor extends NullTemplateVisitor {
if (s.name.startsWith('__') || !s.public || this.completions.has(s.name)) {
continue;
}
// The pipe method should not include parentheses.
// e.g. {{ value_expression | slice : start [ : end ] }}
const shouldInsertParentheses = s.callable && s.kind !== ng.CompletionKind.PIPE;
this.completions.set(s.name, {
name: s.name,
kind: s.kind as ng.CompletionKind,
sortText: s.name,
insertText: s.callable ? `${s.name}()` : s.name,
insertText: shouldInsertParentheses ? `${s.name}()` : s.name,
});
}
}