cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(compiler-cli): do not lower expressions in non-modules (#21649)

Browse Source 
Fixes: #21651

PR Close #21649
This commit is contained in:
Chuck Jazdzewski
2018-01-18 14:36:49 -08:00
committed by Miško Hevery
parent 982eb7bba8
commit ba4ea82f68
2 changed files with 14 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/compiler-cli/test/transformers/lower_expressions_spec.ts
View File

@ -99,7 +99,17 @@ describe('Expression lowering', () => {
.toBeTruthy('did not find the data field');
});
it('should throw a validation execption for invalid files', () => {
it('should not lower a non-module', () => {
const collected = collect(`
declare const global: any;
const ngDevMode: boolean = (function(global: any) {
return global.ngDevMode = true;
})(typeof window != 'undefined' && window || typeof self != 'undefined' && self || typeof global != 'undefined' && global);
`);
expect(collected.requests.size).toBe(0, 'unexpected rewriting');
});
it('should throw a validation exception for invalid files', () => {
const cache = new LowerMetadataCache({}, /* strict */ true);
const sourceFile = ts.createSourceFile(
'foo.ts', `