cargdev/angular
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases Wiki Activity

build: update to latest bazel rules (#22558)

Browse Source 
PR Close #22558
This commit is contained in:
Alex Eagle
2018-03-02 10:10:59 -08:00
parent 0451fd93df
commit ba8df8a3f1
6 changed files with 20 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/bazel/src/esm5.bzl
View File

@ -113,7 +113,7 @@ esm5_outputs_aspect = aspect(
# For some reason, having the compiler output as an input to the action above
# is not sufficient.
"_tsc_wrapped": attr.label(
default = Label("@build_bazel_rules_typescript//internal/tsc_wrapped:tsc_wrapped_bin"),
default = Label("@build_bazel_rules_typescript//internal:tsc_wrapped_bin"),
executable = True,
cfg = "host",
),

2
packages/bazel/src/ngc-wrapped/BUILD.bazel
View File

@ -16,7 +16,7 @@ ts_library(
# Users will get this dependency from node_modules.
"//packages/compiler-cli",
# END-INTERNAL
"@build_bazel_rules_typescript//internal/tsc_wrapped",
"@build_bazel_rules_typescript//internal:tsc_wrapped",
],
)

8
packages/service-worker/worker/src/driver.ts
View File

@ -243,7 +243,7 @@ export class Driver implements Debuggable, UpdateSource {
}
private async handlePush(data: any): Promise<void> {
this.broadcast({
await this.broadcast({
type: 'PUSH',
data,
});
@ -254,7 +254,7 @@ export class Driver implements Debuggable, UpdateSource {
let options: {[key: string]: string | undefined} = {};
NOTIFICATION_OPTION_NAMES.filter(name => desc.hasOwnProperty(name))
.forEach(name => options[name] = desc[name]);
this.scope.registration.showNotification(desc['title'] !, options);
await this.scope.registration.showNotification(desc['title'] !, options);
}
private async reportStatus(client: Client, promise: Promise<void>, nonce: number): Promise<void> {
@ -614,7 +614,7 @@ export class Driver implements Debuggable, UpdateSource {
if (!res.ok) {
if (res.status === 404) {
await this.deleteAllCaches();
this.scope.registration.unregister();
await this.scope.registration.unregister();
}
throw new Error('Manifest fetch failed!');
}
@ -707,7 +707,7 @@ export class Driver implements Debuggable, UpdateSource {
// Firstly, check if the manifest version is correct.
if (manifest.configVersion !== SUPPORTED_CONFIG_VERSION) {
await this.deleteAllCaches();
this.scope.registration.unregister();
await this.scope.registration.unregister();
throw new Error(
`Invalid config version: expected ${SUPPORTED_CONFIG_VERSION}, got ${manifest.configVersion}.`);
}

2
packages/service-worker/worker/test/happy_spec.ts
View File

@ -527,7 +527,7 @@ const manifestUpdateHash = sha1(JSON.stringify(manifestUpdate));
expect(await driver.checkForUpdate()).toEqual(true);
serverUpdate.assertSawRequestFor('/quux.txt');
serverUpdate.clearRequests();
driver.updateClient(await scope.clients.get('default'));
await driver.updateClient(await scope.clients.get('default'));
expect(await makeRequest(scope, '/quux.txt')).toEqual('this is quux v2');
serverUpdate.assertNoOtherRequests();
});