cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

build: enable TSLint on the packages folder (#18459)

Browse Source 
porting PRs #18392 and #18441 to 4.x
This commit is contained in:
Victor Berchet
2017-08-02 15:23:33 -07:00
committed by GitHub
parent 24db1ed938
commit baf4ce0dd0
48 changed files with 133 additions and 112 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/compiler/src/aot/compiler_options.ts
View File

@ -14,5 +14,5 @@ export interface AotCompilerOptions {
translations?: string;
missingTranslation?: MissingTranslationStrategy;
enableLegacyTemplate?: boolean;
enableSummariesForJit?: boolean
enableSummariesForJit?: boolean;
}

2
packages/compiler/src/aot/static_reflector.ts
View File

@ -621,7 +621,7 @@ export class StaticReflector implements CompileReflector {
}
return simplifyInContext(context, value, depth, references + 1);
}
return simplify(value)
return simplify(value);
});
}
return IGNORE;

2
packages/compiler/src/ml_parser/ast.ts
View File

@ -142,7 +142,7 @@ export function findNode(nodes: Node[], position: number): HtmlAstPath {
return true;
}
}
}
};
visitAll(visitor, nodes);

2
packages/compiler/src/output/output_ast.ts
View File

@ -228,7 +228,7 @@ export class ReadVarExpr extends Expression {
set(value: Expression): WriteVarExpr {
if (!this.name) {
throw new Error(`Built in variable ${this.builtin} can not be assigned to.`)
throw new Error(`Built in variable ${this.builtin} can not be assigned to.`);
}
return new WriteVarExpr(this.name, value, null, this.sourceSpan);
}

2
packages/compiler/test/aot/compiler_spec.ts
View File

@ -28,7 +28,7 @@ describe('compiler (unbundled Angular)', () => {
describe('aot source mapping', () => {
const componentPath = '/app/app.component.ts';
const ngComponentPath = 'ng:///app/app.component.ts'
const ngComponentPath = 'ng:///app/app.component.ts';
let rootDir: MockDirectory;
let appDir: MockDirectory;

2
packages/compiler/test/i18n/extractor_merger_spec.ts
View File

@ -490,7 +490,7 @@ export function main() {
.toEqual(
'<span someAttr="ok">foo</span><div>{count, plural, =0 {<p title="foo"></p>}}</div>');
});
})
});
});
}

2
packages/compiler/test/output/output_jit_spec.ts
View File

@ -31,5 +31,5 @@ export function main() {
expect(Object.keys(args).length).toBe(20);
});
});
})
});
}

28
packages/compiler/test/parse_util_spec.ts
View File

@ -6,23 +6,21 @@
* found in the LICENSE file at https://angular.io/license
*/
import {ParseError, ParseErrorLevel, ParseLocation, ParseSourceFile, ParseSourceSpan} from '../src/parse_util'
import {ParseError, ParseErrorLevel, ParseLocation, ParseSourceFile, ParseSourceSpan} from '../src/parse_util';
export function main() {
describe(
'ParseError',
() => {
it('should reflect the level in the message', () => {
const file = new ParseSourceFile(`foo\nbar\nfoo`, 'url');
const start = new ParseLocation(file, 4, 1, 0);
const end = new ParseLocation(file, 6, 1, 2);
const span = new ParseSourceSpan(start, end);
describe('ParseError', () => {
it('should reflect the level in the message', () => {
const file = new ParseSourceFile(`foo\nbar\nfoo`, 'url');
const start = new ParseLocation(file, 4, 1, 0);
const end = new ParseLocation(file, 6, 1, 2);
const span = new ParseSourceSpan(start, end);
const fatal = new ParseError(span, 'fatal', ParseErrorLevel.ERROR);
expect(fatal.toString()).toEqual('fatal ("foo\n[ERROR ->]bar\nfoo"): url@1:0');
const fatal = new ParseError(span, 'fatal', ParseErrorLevel.ERROR);
expect(fatal.toString()).toEqual('fatal ("foo\n[ERROR ->]bar\nfoo"): url@1:0');
const warning = new ParseError(span, 'warning', ParseErrorLevel.WARNING);
expect(warning.toString()).toEqual('warning ("foo\n[WARNING ->]bar\nfoo"): url@1:0');
});
});
const warning = new ParseError(span, 'warning', ParseErrorLevel.WARNING);
expect(warning.toString()).toEqual('warning ("foo\n[WARNING ->]bar\nfoo"): url@1:0');
});
});
}